[Aptitude-devel] Bug #498239: aptitude: warnings, status printed twice

[Boris Egorov]

Hello folks.

I found a problem which triggers bug #498239. You can see it in 
src/cmdline/cmdline_do_action.cc:307 or at this long path: 
https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=aptitude/aptitude.git;a=blob;f=src/cmdline/cmdline_do_action.cc;h=8d0883797daee17666eb63f253e65bd841409c74;hb=0a2795f113e2588fc4c6b4091cf32ccff49e4974#l307

We do a two runs over all the packages if we have auto-install turned on 
(see comment). So we call function cmdline_applyaction from 
src/cmdline/cmdline_action.cc:221 twice (if we have one action as in bug 
inputs). This function at line 375 and overloaded one at line 582 
triggers the bug.

How it should be fixed? All overloaded functions cmdline_applyaction has 
argument allow_auto which set to true if current iteration is not first. 
I think we can not to print warnings if allow_auto is true. What do you 
think?

Sorry if I'm doing something wrong, I haven't contributed to debian 
before. I found the bug thanks to how-can-i-help and want to fix it.

-- 
Best regards,
Boris Egorov