[Aptitude-devel] Bug#265013: Unnecessary computations on some key combinations

[Manuel A. Fernandez Montecelo]

Control: tags -1 + pending


Hi Enrico,

2004-08-11 12:46 Enrico Zini:
>Package: aptitude
>Version: 0.2.15.6-1
>Severity: minor
>
>Hello,
>
>thanks a lot for aptitude!
>
>I found a minor flaw, which however gets quite annoying in slow
>machines.
>
>I set up aptitude so that after acting on a package, the cursor moves to
>the next one.  This is very handy to me, and one of the things I like to
>do on old installations is to fire up aptitude, holding down 'M' until I
>mark all packages as auto-installed and then manually select the ones I
>really need: in that case I can get rid of stuff left around from past
>updates, and I make a good initialization of the auto-installed metadata.
>
>However, as 'M' is pressed on the last package, the cursor can't move
>down, so pressing 'M' again tries to mark an already marked package,
>resulting on noticeable combination.  If I was holding 'M' down to mark
>a list of packages, I may get that computation performed like 30 times,
>and have to wait quite some time for aptitude to finish before I get my
>cursor again.
>
>So, after all this background, the report is: if a package is already
>marked 'A', pressing 'M' should probably just do nothing.

I thought that I wouldn't notice it, 11 years later and with a recent
and very fast machine, but it is still very noticeable.

So I just fixed it, for both mark and unmark auto (m and M), marking as
+pending.


BTW, in the unlikely case that you don't already know this, if one does
want to mark a lot of packages, it is probably more efficient to press
the key on whole subtrees (e.g. section "libs").


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>