[Aptitude-devel] Bug#926371: aptitude: FTBFS with gcc 8.3

[Santiago Vila]

Package: src:aptitude
Version: 0.8.11-7
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules binary-indep
dh binary-indep --builddirectory=build --dbgsym-migration=aptitude-dbg
   dh_update_autotools_config -i -O--builddirectory=build -O--dbgsym-migration=aptitude-dbg
   dh_autoreconf -i -O--builddirectory=build -O--dbgsym-migration=aptitude-dbg
autoreconf: configure.ac: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION
   debian/rules override_dh_auto_configure-indep
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_configure -- \
    --htmldir='${docdir}/html' \
    --program-transform='s&aptitude$&aptitude-curses&' \
    --disable-boost-lib-checks \
     
	cd build && ../configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --runstatedir=/run --disable-maintainer-mode --disable-dependency-tracking --htmldir=\${docdir}/html --program-transform=s&aptitude\$&aptitude-curses& --disable-boost-lib-checks
configure: WARNING: unrecognized options: --disable-maintainer-mode

[... snipped ...]

Making all in mocks
make[6]: Entering directory '/<<PKGBUILDDIR>>/build/src/generic/views/mocks'
g++ -DHAVE_CONFIG_H -I. -I../../../../../src/generic/views/mocks -I../../../..  -I../../../.. -I../../../../.. -I../../../../../src -I../../../../../intl -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -DHELPDIR=\"/usr/share/aptitude\" -DPKGDATADIR=\"/usr/share/aptitude\"  -I/usr/include/sigc++-2.0 -I/usr/lib/x86_64-linux-gnu/sigc++-2.0/include -I/usr/lib/x86_64-linux-gnu/cwidget -I/usr/include/sigc++-2.0 -I/usr/lib/x86_64-linux-gnu/sigc++-2.0/include    -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -D_REENTRANT -std=gnu++17 -Wall  -c -o download_progress.o ../../../../../src/generic/views/mocks/download_progress.cc
In file included from /usr/include/boost/mpl/aux_/include_preprocessed.hpp:37,
                 from /usr/include/boost/mpl/bind.hpp:50,
                 from /usr/include/boost/mpl/lambda.hpp:18,
                 from /usr/include/boost/mpl/iter_fold.hpp:20,
                 from /usr/include/boost/variant/detail/initializer.hpp:28,
                 from /usr/include/boost/variant/variant.hpp:30,
                 from /usr/include/boost/variant.hpp:17,
                 from ../../../../../src/generic/views/download_progress.h:25,
                 from ../../../../../src/generic/views/mocks/download_progress.h:26,
                 from ../../../../../src/generic/views/mocks/download_progress.cc:23:
/usr/include/boost/mpl/aux_/preprocessed/gcc/bind.hpp:466:67: error: template parameter 'template<class T1, class T2, class T3> class F'
 template< template< typename T1, typename T2, typename T3 > class F, typename Tag >
                                                                   ^
In file included from /usr/include/boost/mpl/aux_/include_preprocessed.hpp:37,
                 from /usr/include/boost/mpl/quote.hpp:45,
                 from /usr/include/boost/mpl/aux_/full_lambda.hpp:25,
                 from /usr/include/boost/mpl/lambda.hpp:22,
                 from /usr/include/boost/mpl/iter_fold.hpp:20,
                 from /usr/include/boost/variant/detail/initializer.hpp:28,
                 from /usr/include/boost/variant/variant.hpp:30,
                 from /usr/include/boost/variant.hpp:17,
                 from ../../../../../src/generic/views/download_progress.h:25,
                 from ../../../../../src/generic/views/mocks/download_progress.h:26,
                 from ../../../../../src/generic/views/mocks/download_progress.cc:23:
/usr/include/boost/mpl/aux_/preprocessed/gcc/quote.hpp:64:8: error: redeclared here as 'template<class P1, class P2, class P3> class F'
 struct quote3
        ^~~~~~
make[6]: *** [Makefile:412: download_progress.o] Error 1
make[6]: Leaving directory '/<<PKGBUILDDIR>>/build/src/generic/views/mocks'
make[5]: *** [Makefile:476: all-recursive] Error 1
make[5]: Leaving directory '/<<PKGBUILDDIR>>/build/src/generic/views'
make[4]: *** [Makefile:395: all-recursive] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/build/src/generic'
make[3]: *** [Makefile:683: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/build/src'
make[2]: *** [Makefile:718: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/build'
make[1]: *** [Makefile:600: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/build'
dh_auto_build: cd build && make -j1 returned exit code 2
make: *** [debian/rules:22: binary-indep] Error 2
dpkg-buildpackage: error: debian/rules binary-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends but hopefully relevant enough.

The build was made in my autobuilder with "dpkg-buildpackage -A"
and it also fails here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/aptitude.html

Note 1: I've just triggered rebuilds in reproducible-builds, it may not fail everywhere yet.

Note 2: I've used "FTBFS with gcc 8.3" because this seems to be the
recurring issue with C++ code and GCC being more strict every day,
feel free to retitle if this description is not good enough.

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.