[Aptitude-devel] Bug#950334: Bug#950334: aptitude: Help -> User's Manual contains special characters

[Axel Beckert]

Hi Diego,

Diego Escalante wrote:
> This is actually a broader bug and not related to specific locales.

Suspected that, yes. But then again, not in the way you noticed. (I
suspected ISO-Latin encoded chacracters in source code files, e.g.
French or German contributor names, not hardcoded encoding names…)

> The issue is that `src/ui.cc` defaults to transcoding the README files
> to ISO-8859-1, and since all the README files are already UTF-8, you get
> glitchy glyphs.

I guess I wasn't aware of that when coverting them after Lintian
warnings or so. At least I did that for many of my packages. Not sure
if I was the one who did it with aptitude, but chances are not that
low. ;-)

> I'm attaching a patch for this specific issue, but note that I have an
> open MR which includes this and a few more encoding related fixes:
>   https://salsa.debian.org/apt-team/aptitude/-/merge_requests/10/commits

Thanks a lot!

Funnily
https://salsa.debian.org/apt-team/aptitude/-/merge_requests/10/diffs
doesn't really show the changes as it at least partially seems to
convert the encoding line by line. So both, old and especially new
look good. :-)

> Note also that I wasn't able to properly test this because of the
> current FTBFS in:
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966875

Ack. Yeah, I'm aware of it. Building with gcc 9 instead of 10 should
work, in case you're curious to see if it flies. :-)

> But that said, this is merely a string replacement, shouldn't be
> problematic.

Ack, I think so, too.

I though think we should not merge it before that FTBFS is fixed.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE