[Aptitude-devel] Bug#934135: Bug#934135: Bug#934135: aptitude: depends on libparse-debianchangelog-perl that has no upstream maintainer

[Axel Beckert]

Hi intrigeri,

intrigeri wrote:
> Guillem Jover (2019-08-09):
> > After some thought, I think a local aptitude-specific wrapper might be
> > even better and obviates the question of whether dpkg-parsechangelog
> > should be moved or not. :)
> 
> FWIW, this makes sense to me.

Ack, and I'm actually on it. Tried to incorporate it last weekend.

Problem: It doesn't work for me, no more highlighting of new changelog
entries — which I is why I haven't pushed my changes yet.

Maybe I should push them to a branch. Will do.

> > See the attached patch, which has seen no testing, but can do that
> > once and if it is deemed a good path forward.
> 
> Thanks a lot!

Yes. There's IIRC one typo in it, but without that fix, it IIRC
doesn't even compile.

> Dear Aptitude maintainers, FYI this is now the last remaining blocker
> for the removal of libparse-debian-changelog-perl, so I'm trying
> to facilitate the integration of Guillem's patch:
> 
> I have applied Guillem's patch and fixed the typo mentioned below, on
> top of current sid's 0.8.12-3 (after disabling the build of doc
> translations as this makes the package FTBFS for me with current po4a;
> same on the Reproducible Builds infra¹), and I did these tests:
> 
>  - `aptitude changelog apt` works

Yes, but as far as I can see in this case,
libparse-debianchangelog-perl seems not used at all, based on the
behaviour with 0.8.12-3. :-)

(Which might be a kind of missing feature, but is probably overkill,
because it would bloat up what is done to accomplish that massively.
:-)

>  - In the Aptitude UI I could view the changelog of both
>    installed and non-installed packages.

Irrelevant. You need to test it on upgradable packages. (And check how
it looks without the patch first: All entries between the currently
installed version and the new version should be bold.

> I'm not sure if any of those exercises the affected code path.
>
> I'm happy to do more tests if it helps fix this bug, but I would
> need some guidance regarding what/how to test :)

See above.

> > -dist_bin_SCRIPTS = aptitude-create-state-bundle aptitude-run-state-bundle
> > +dist_bin_SCRIPTS = apitude-changelog-parser \
> > +	aptitude-create-state-bundle aptitude-run-state-bundle
> 
> Typo: apitute-changelog-parser → aptitude-changelog-parser

Ack.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE