[Aptitude-devel] Bug#1012895: aptitude: ftbfs with GCC-12

[Paul Wise]

Control: tags -1 + patch

On Thu, 16 Jun 2022 12:07:38 +0000 Matthias Klose wrote:

> The package fails to build in a test rebuild on at least amd64 with
> gcc-12/g++-12, but succeeds to build with gcc-11/g++-11. The
> severity of this report will be raised before the bookworm release.

I tried to build aptitude, found it fails due to cwidget bug #1015925.

I tried to look at this failure, which also happens after fixing that.

I don't know enough C++ but seems that the operator<< function in the
test_parsers.cc file taking std::optional as a parameter is not being
found by GCC 12 even though it should be found.

The g++ output was verbose but the clang++ output was very clear.

The issue is that the operator<< functions are not declared before the
call site, so forward declarations before HelperMacros.h are needed:

   #include <generic/util/parsers.h>
   
   template<typename T>
   std::ostream &operator<<(std::ostream &out, const std::optional<T> o);
   
   template<typename T>
   std::ostream &operator<<(std::ostream &out, const std::vector<T> v);
   
   #include <cppunit/extensions/HelperMacros.h>
   
I'm not sure how to contribute this change to the package because this
should be a native package but isn't and has debian/patches/ but also
an upstream master branch that seems to be unused.

I suggest merging the contents of debian/patches/ to the upstream
master branch and then cherry-picking the FTBFS patches to a new minor
release branch instead of using debian/patches/.

I've filed two merge requests with two different approaches, one is a
commit for the master branch and one a patch for the debian-sid branch.

https://salsa.debian.org/apt-team/aptitude/-/merge_requests/14
https://salsa.debian.org/apt-team/aptitude/-/merge_requests/13

-- 
bye,
pabs

https://wiki.debian.org/PaulWise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/aptitude-devel/attachments/20220724/538ef77b/attachment.sig>