[Aptitude-devel] Bug#1019447: aptitude: Wrong "Press Return to continue" after succesful installation

[Aleksey Midenkov]

Package: aptitude
Version: 0.8.13-3
Severity: normal
Tags: patch

Since some version aptitude started to behave strangely: it asks user
interaction after each successful installation.

Press Return to continue, 'q' followed by Return to quit.

That is strange because 'q' returns first into the UI and then quits.
So no obvious reason to use 'q' from the above interaction because 'q'
also works from the UI. I guess the above pause was added to display
the errors if any happened but the condition in the code for that was
chosen wrongly. I hope you will find the below patch well-suited for
stopping bugging you with that useless pause.

--- b/src/ui.cc 2020-05-21 06:32:38.000000000 +0300
+++ b/src/ui.cc 2022-09-09 13:41:49.752101187 +0300
@@ -1276,7 +1276,7 @@
     pkgPackageManager::OrderResult rval = f(-1);

     bool quit_after_dpkg_run = false;
-    if(rval != pkgPackageManager::Incomplete)
+    if(rval != pkgPackageManager::Completed)
       {
  cout << _("Press Return to continue, 'q' followed by Return to
quit.") << endl;

-- 
@midenok