[Aptitude-devel] Bug#1065435: Bug#1065435: aptitude: FTBFS on armhf and armel (probably -Werror=implicit-function-declaration related)

[Axel Beckert]

Hi Steinar and Christoph,

Steinar H. Gunderson wrote:
> struct timeval
> {
> #ifdef __USE_TIME_BITS64
>   __time64_t tv_sec;            /* Seconds.  */
>   __suseconds64_t tv_usec;      /* Microseconds.  */
> #else 
>   __time_t tv_sec;              /* Seconds.  */
>   __suseconds_t tv_usec;        /* Microseconds.  */
> #endif
> };
> #endif
> 
> But the fix is straightforward, no? Just change the offending test to something like
> 
>   CPPUNIT_ASSERT_EQUAL(static_cast<decltype(c.tv_usec)>(999999), c.tv_usec);
> 
> and it should work no matter what type c.tv_usec is. Or, if you prefer
> brace-initialization (which would prevent you from ever writing in a too-big
> value, like 999999999999999 or something):
> 
>   CPPUNIT_ASSERT_EQUAL(decltype(c.tv_usec){999999}, c.tv_usec);
> 
> /* Steinar */

Thanks for the patch!

Christoph Biedl wrote:
> Therefore, any progress on this?

Not before the patch (hints) from Steinar. (Although there's also a
recent merge request mentioning some FTBFS fix, but it's unclear if
this issue is meant or something else. Will have to look into it,
too.)

> Do you need help?

I'm happy about any help with aptitude as we currently don't really
have any active upstream developer. C++ is not something that I'm
particularly good at.

> I didn't get very far at a first glance, aptitude's build
> dependencies are currently uninstallable, at least in arm{el,hf}.

I got my sid armhf Raspi fixed today (it stopped booting a while ago,
seemed to have been a usrmerge related issue), so I can now test
patches locally on armhf again.

Will try to get an upload done based on Steinar's patch instructions
soon-ish. But I first need to get the Raspi uptodate with the current
state of Sid.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE