[Babel-users] [PATCH] Fix resetting of rp_filter to its old value on shutdown

[Matthias Schiffer]

Of course rp_filter should be reset to its old value, and not to the old
accept_redirects value.

Signed-off-by: Matthias Schiffer <mschiffer at universe-factory.net>
---

Hi,
I've already sent this patch to jech a few days ago, but I guess the mailing
list is a better place for it.

This little copy&paste mistake really confused us when on one of our servers
all.rp_filter was unexpectedly set to 1 after testing babeld...

Regards, 
Matthias Schiffer

 kernel_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel_netlink.c b/kernel_netlink.c
index bf08810..0a85009 100644
--- a/kernel_netlink.c
+++ b/kernel_netlink.c
@@ -568,7 +568,7 @@ kernel_setup(int setup)
 
         if(old_rp_filter >= 0) {
             rc = write_proc("/proc/sys/net/ipv4/conf/all/rp_filter",
-                            old_accept_redirects);
+                            old_rp_filter);
             if(rc < 0) {
                 perror("Couldn't write rp_filter knob.\n");
                 return -1;
-- 
1.8.2