[Babel-users] [PATCH v2] Smarter sysctl handling

Juliusz Chroboczek jch at pps.univ-paris-diderot.fr
Wed Aug 12 19:26:23 UTC 2015


Thanks Toke.

1. Please split that into two patches, one that changes the default
behaviour, and one that includes the new patch.

2. The flag should be called "no-kernel-tweaks" or something like that,
and should unconditionally disable any kernel tweaks rather than merely
continuing if tweaking fails.

3. You also need to change the BSD code (in kernel_socket.c).  If you're
too lazy, feel free to fail in case the flag has been specified with
a message that says this is not supported on BSD.

> +#define WANT_FORWARDING 1
> +#define WANT_IPV4_FORWARDING 1
> +#define WANT_ACCEPT_REDIRECTS 0
> +#define WANT_RP_FILTER 0

If you wish, although I would find it clearer if you just put the values
in the code.

Other than that, looks fine to me.

-- Juliusz



More information about the Babel-users mailing list