[Babel-users] [PATCH v3 1/2] Rework sysctl writing to only write when needed.

[Juliusz Chroboczek]

> +            if(s->was != s->want) {
> +                rc = write_proc(s->name, s->want);
> +                if(rc < 0) {
> +                    perror("Couldn't write sysctl");
> +                    return -1;
> +                }
> +            }

Shouldn't this say

    rc = write_proc(s->name, s->was);

?

> +        for(i=0; i<NUM_SYSCTLS; i++) {
> +            s = &sysctl_settings[i];
> +            if(s->was && s->was != s->want) {
> +                rc = write_proc(s->name,s->want);
> +                if(rc < 0) {
> +                    perror("Couldn't write sysctl");
> +                    return -1;
> +                }

Same here.

-- Juliusz