[Babel-users] Main Loop Frequency
Gabriel Kerneis
gabriel at kerneis.info
Tue Mar 7 21:06:05 UTC 2017
On Tue, Mar 7, 2017, at 21:05, Juliusz Chroboczek wrote:
> > But it looks like timeval_min is ignoring sub-second values, which was
> > the original question:
> > https://github.com/jech/babeld/blob/556af3c2667f8802f243a46067d45b7430bf943b/util.c#L115
>
> No, it's not. It calls timeval_compare, which doesn't ignore
> milliseconds.
>
> (It special-cases the cases of tv_sec=0, which is what may have confused
> you.)
And I claim that this special case is broken :
struct timeval x = {0, 500};
timeval_min(&tv, &x)
will leave tv unchanged even if it is larger than 500 microseconds.
Or did I miss something about the intended semantics of this function?
--
Gabriel
More information about the Babel-users
mailing list