[Babel-users] The b8fb6d896a234eaa06 commit in master

[Stanisław Drozd]

I didn't mean any present incorrect behaviour, but rather a weakness which
may
(or may not) reappear at some point later and cause painful bugs (a
zeroed-out
struct stands out way more than a gibberish-filled uninitialized one).
`do_filter` is two frames deeper from that `filter_result`'s declaration -
and
that gives opportunity to use it before it's ready.

Personally I'd lose the `filter_result.src_prefix = NULL;`in xroute.c:290
and leave the `= {0};` alone.

Thanks,
Stanislaw

pt., 9 mar 2018 o 14:38 użytkownik Juliusz Chroboczek <jch at irif.fr> napisał:

> >> I noticed that there's this new commit (b8fb6d896a234eaa06) which
> removes
> >> explicit initialization from check_xroutes() in xroute.c.
>
> > Fixed, thanks.
>
> Er, no.  do_filter unconditionally initialises the result, so the code is
> correct.  Am I missing something?
>
> -- Juliusz
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/babel-users/attachments/20180309/1359b999/attachment.html>