[Babel-users] [PATCH] Fix ifup bug in send_multicast

[Christof Schulze]

Hi Dave,

we could get away with dropping the continue statement altogether and 
keeping the comparison as it is. This looks a little clearer to me.
Based on you work, please find below my suggestion

Cheers

Christof
---
   message.c | 7 +++----
   1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/message.c b/message.c
index 043e4b6..e78071c 100644
--- a/message.c
+++ b/message.c
@@ -1747,8 +1747,7 @@ send_multicast_request(struct interface *ifp,
           struct interface *ifp_auxn;
           FOR_ALL_INTERFACES(ifp_auxn) {
               if(if_up(ifp_auxn))
-                continue;
-            send_multicast_request(ifp_auxn, prefix, plen, src_prefix, src_plen);
+                send_multicast_request(ifp_auxn, prefix, plen, src_prefix, src_plen);
           }
           return;
       }
@@ -1765,10 +1764,10 @@ send_multicast_request(struct interface *ifp,
               if(neigh->ifp == ifp) {
                   send_request(&neigh->buf, prefix, plen,
                                src_prefix, src_plen);
-            } else {
-                send_request(&ifp->buf, prefix, plen, src_prefix, src_plen);
               }
           }
+    } else {
+        send_request(&ifp->buf, prefix, plen, src_prefix, src_plen);
       }
   }
   
-- 
2.11.0