[Babel-users] [PATCH 3/3] Always use the same metric for unreachable routes

[Christof Schulze]

Juliusz,

On Thu, Sep 27, 2018 at 12:37:01AM +0200, Juliusz Chroboczek wrote:
>> --- a/kernel_netlink.c
>> +++ b/kernel_netlink.c
>
>> +static int ipv4_metric = 0;
>> +static int ipv6_metric = 1024;
>
>That's exactly the wrong layer at which to do that.  Policy should be
>happening at least 17 layers higher.
>
>What problem is that intended to solve?
I also struggled with this patch. Those variables are set and used only 
when an unreachable route is set. Couldn't we get rid of those two 
variables again and just set RTN_UNREACHABLE and not modify the metric?

Christof

-- 
()  ascii ribbon campaign - against html e-mail
/\  against proprietary attachments

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/babel-users/attachments/20180927/acbcafdd/attachment.sig>