[Babel-users] [PATCH] Use per-table dumps on kernels where this is available

Toke Høiland-Jørgensen toke at toke.dk
Sat Apr 16 21:03:24 BST 2022


Daniel Gröber <dxld at darkboxed.org> writes:

> Hi Toke,
>
> I did some deeper testing on this. It seems to me while STRICT_CHK enables
> the route filtering and that bit does seem to work it actually breaks
> something else as babeld is no longer installing any routes after applying
> this patch (when it did before). The xroutes are missing from the status
> socket dump too and all interfaces show as down.
>
> My guss is the RTM_GETADDR dump is breaking as inet6_dump_addr also changes
> behaviour based on the strict_check flag. I'll need to do some more digging
> later to see what's going on there.

Hmm, so the addr dump needs to use a different message type; so the
patch is wrong. However, 'struct ifaddrmsg' is smaller than 'struct
rtmsg', so I don't see how this should actually make things fail...

Anyway, I'll send a v2 with the right command type for addresses, maybe
I overlooked some way that will make things fail...

-Toke



More information about the Babel-users mailing list