[Debconf-devel] Bug#542175: updated patch

Colin Watson cjwatson at ubuntu.com
Fri Dec 17 13:50:53 UTC 2010


Thanks for this patch, Jani.

I agree with the general principle; libgnome/libgnomeui are in general
deprecated and their functionality is being moved into GTK+.  We need to
adopt the more modern interfaces if this frontend is going to continue
to work with GTK+ 3.0.  Plus, libgnome2-perl is not negligibly small and
very little other than debconf uses it any more.

Martin Pitt and I both worked on updating this patch to current debconf
and fixing some further bugs, with the following combined changelog:

  [ Martin Pitt ]
  * Debconf/FrontEnd/Gnome.pm: Port from Gnome2::Druid to Gtk2::Assistant.
    Original patch by Jani Monoses, thanks! (LP: #415038)
  * Debconf/Element/Gnome/Select.pm: Drop unused Gnome2 import.
  * debian/control: Change libgnome2-perl suggestion to libgtk2-perl
    accordingly.

  [ Colin Watson ]
  * Fix Gnome frontend to honour backup capability again, and make backup
    page handling work properly.
  * Version libgtk2-perl Suggests to match the upstream version where
    Gtk2::Assistant was introduced.
  * Convert from deprecated Gtk2::Combo to Gtk2::ComboBox.
  * Make sure you can't press Forward on a progress bar in the Gnome
    frontend.

There are probably a few more uses of deprecated interfaces to clean up,
but in general I'm happy with this now, and would apply it to debconf
trunk except for the fact that Debian is currently frozen.  I have to go
ahead and apply it to Ubuntu because we're under serious space
constraints for our next release and need to work to get rid of
libgnome2-perl as part of that; but with my Debian hat on, unless Joey
objects, I'll apply this to Debian as soon as we thaw.

Cheers,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtkassistant.patch
Type: text/x-diff
Size: 9145 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debconf-devel/attachments/20101217/555f1cd8/attachment.patch>


More information about the Debconf-devel mailing list