[Debconf-devel] Bug#711693: debconf-set-selection: leave clear text password entries behind in templates.dat

[Joey Hess]

Petter Reinholdtsen wrote:
> 		$template->default($content);

> I am unable to understand why the default value is updated by
> debconf-set-selections, but believe it is a bad idea to do so for
> templates with the password type.

I seem to have introduced that when adapting your original version of
debconf-set-selections in #214617. The original version set Default: 
in the dummy template, but I can't see a reason to do that either,
and the current code does not. 

commit 4d999aeea490f938931129b87435eeff0c2453d1
Author: Joey Hess <joey at kitenet.net>
Date:   Mon Jun 10 10:33:35 2013 -0400

    debconf-set-selections: Do not change the default template value when overriding the value of existing questions. Closes: #711693

diff --git a/debconf-set-selections b/debconf-set-selections
index 3a9a747..7d99a30 100755
--- a/debconf-set-selections
+++ b/debconf-set-selections
@@ -2,7 +2,7 @@
 
 =head1 NAME
 
-debconf-set-selections - insert new default values into the debconf database
+debconf-set-selections - insert new values into the debconf database
 
 =cut
 
@@ -115,17 +115,13 @@ sub load_answer {
 	
 	info "Loading answer for '$label'";
 
-	# Set up the template. If it already exists, override its default
-	# value.
+	# Set up the template.
 	my $template=Debconf::Template->get($label);
 	if (! $template) {
 		$template=Debconf::Template->new($label, $owner, $type);
 		$template->description("Dummy template");
 		$template->extended_description("This is a fake template used to pre-seed the debconf database. If you are seeing this, something is probably wrong.");
 	}
-	else {
-		$template->default($content);
-	}
 	$template->type($type);
 	
 	# The question should already exist, it was created along with the
diff --git a/debian/changelog b/debian/changelog
index 9c39ded..4982811 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,8 @@ debconf (1.5.51) UNRELEASED; urgency=low
 
   * Fix warning when /var/cache/debconf is missing.
     Closes: #709928
+  * debconf-set-selections: Do not change the default template
+    value when overriding the value of existing questions. Closes: #711693
 
  -- Joey Hess <joeyh at debian.org>  Sun, 26 May 2013 21:01:21 -0400

-- 
see shy jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debconf-devel/attachments/20130610/f5f232c2/attachment.pgp>