[Debian-astro-maintainers] Bug#748409: Conflicting return types of setnfit

[Michael Tautschnig]

Package: cpl-plugin-vimos
Version: 2.9.14+dfsg-1
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
libtool: link: g++  -fPIC -DPIC -shared -nostdlib /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/crti.o /usr/lib/gcc/x86_64-linux-gnu/4.8/crtbeginS.o  .libs/vmadf.o .libs/vmadfifutable.o .libs/vmastrometrictable.o .libs/vmccdtable.o .libs/vmcpl.o .libs/vmcube.o .libs/vmdetector.o .libs/vmdistmodels.o .libs/vmextractiontable.o .libs/vmfit.o .libs/vmgalaxytable.o .libs/vmgrismtable.o .libs/vmidstable.o .libs/vmifuextraction.o .libs/vmifufibers.o .libs/vmifuflat.o .libs/vmifuimage.o .libs/vmifusky.o .libs/vmifusphotcalib.o .libs/vmifutable.o .libs/vmifutypes.o .libs/vmifuutils.o .libs/vmimage.o .libs/vmimagearray.o .libs/vmimageset.o .libs/vmimgastrometry.o .libs/vmimgphotcalib.o .libs/vmimgpreprocessing.o .libs/vmimgextraction.o .libs/vmimgresampling.o .libs/vmimgutils.o .libs/vmlinecatalog.o .libs/vmmath.o .libs/vmmatrix.o .libs/vmmosextraction.o .libs/vmmosflat.o .libs/vmmosfringes.o .libs/vmmosmodels.o .libs/vmmossky.o .libs/vmmossphotcalib.o .libs/vmmosutils.o .libs/vmmoswavecalib.o .libs/vmobjecttable.o .libs/vmphotometrictable.o .libs/vmqcutils.o .libs/vmsextractor.o .libs/vmsphottable.o .libs/vmstarmatchtable.o .libs/vmstartable.o .libs/vmtable.o .libs/vmtablearray.o .libs/vmtypes.o .libs/vmutils.o .libs/vmwcsutils.o .libs/vmwindowtable.o .libs/vmifu.o .libs/vmspecphottable.o .libs/vmstdfluxtable.o .libs/vmextincttable.o .libs/moses.o .libs/fors_tools.o .libs/fors_paf.o .libs/fors_dfs.o .libs/fors_qc.o .libs/vimos_calib_impl.o .libs/vimos_science_impl.o .libs/vimos_calib_mult.o .libs/VimosIfuWCS.o .libs/VimosUtils.o .libs/TwoDLinearWCS.o  -Wl,--whole-archive ../irplib/.libs/libirplib.a ../external/libwcs/.libs/libvimoswcs.a -Wl,--no-whole-archive  -Wl,-rpath -Wl,/srv/jenkins-slave/workspace/sid-goto-cc-cpl-plugin-vimos/cpl-plugin-vimos-2.9.14+dfsg/libpil/pil/.libs -Wl,-rpath -Wl,/usr/lib/x86_64-linux-gnu/vimos -L/usr/lib/x86_64-linux-gnu ../libpil/pil/.libs/libpil.so -lcfitsio -lcpldfs -lcpldrs -lcplui -lcplcore -lcext -lnsl -L/usr/lib/gcc/x86_64-linux-gnu/4.8 -L/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu -L/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../lib -L/lib/x86_64-linux-gnu -L/lib/../lib -L/usr/lib/../lib -L/usr/lib/gcc/x86_64-linux-gnu/4.8/../../.. -lstdc++ -lm -lc -lgcc_s /usr/lib/gcc/x86_64-linux-gnu/4.8/crtendS.o /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/crtn.o  -O2 -Wl,-z -Wl,relro   -Wl,-soname -Wl,libvimos.so.0 -o .libs/libvimos.so.0.0.0

file matchstar.c line 1496: error: conflicting function declarations "setnfit"
old definition in module vmwcsutils file vmwcsutils.h line 49
signed int (signed int)
new definition in module matchstar file matchstar.c line 1496
void (signed int nfit)
make[3]: *** [libvimos.la] Error 1
make[3]: Leaving directory `/srv/jenkins-slave/workspace/sid-goto-cc-cpl-plugin-vimos/cpl-plugin-vimos-2.9.14+dfsg/vimos'
make[2]: *** [all-recursive] Error 1

Indeed this seems just an inconsistency of declarations here, as the declaration
in vmwcsutils.h wrongly specifies the return type as int - but no function call
actually uses the return value. Fixing the forward declaration will ensure no
one inadvertently uses the non-existent return value.

Best,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-astro-maintainers/attachments/20140516/ea1d7d52/attachment.sig>