[Debian-astro-maintainers] Bug#750748: cpl-plugin-xshoo FTBFS on testing for mips/mipsel

[Dejan Latinovic]

Package: cpl-plugin-xshoo
Version: 2.4.0+dfsg-1
Tags: sid patch
Severity: important
Justification: FTBFS
User: debian-mips-dev-discuss at lists.alioth.debian.org
Usertags: mips-patch



While trying to build cpl-plugin-xshoo on mips/mipsel architecture,
build fails on testing with an error:

> =================================
> 3 of 79 tests failed
> Please report to usd-help at eso.org
> =================================
> make[4]: *** [check-TESTS] Error 1

Here are 3 tests that fails:
> FAIL: test_xsh_detect_continuum 
> FAIL: test_xsh_flux_conservation
> FAIL: test_xsh_correl_gaussians

Tests test_xsh_detect_continuum and test_xsh_flux_conservation,
fails with an error:

> [ INFO  ] Test-XSH_DETECT_CONTINUUM: detect_continuum
> [ INFO  ] Test-XSH_DETECT_CONTINUUM:    recipe_id: xsh_orderpos
> [ INFO  ] Test-XSH_DETECT_CONTINUUM: Create Order List with 3 orders
> [ INFO  ] Test-XSH_DETECT_CONTINUUM: Create polynomials of degree 2
> [ INFO  ] Test-XSH_DETECT_CONTINUUM: Add to order list
> [ INFO  ] Test-XSH_DETECT_CONTINUUM: config update 0
> [ INFO  ] Test-XSH_DETECT_CONTINUUM:   pre_overscan=0
> [ INFO  ] Test-XSH_DETECT_CONTINUUM: Saving PRE image "dtc_img_pre.fits"
> [ ERROR ] Test-XSH_DETECT_CONTINUUM: An error occurred, dumping error trace:
> [ ERROR ] Test-XSH_DETECT_CONTINUUM:  
> [ ERROR ] Test-XSH_DETECT_CONTINUUM: Illegal output
> [ ERROR ] Test-XSH_DETECT_CONTINUUM:  in [3]cpl_table_new_column() at cpl_table.c:1161
> [ ERROR ] Test-XSH_DETECT_CONTINUUM:  
> [ ERROR ] Test-XSH_DETECT_CONTINUUM: Illegal output
> [ ERROR ] Test-XSH_DETECT_CONTINUUM:  in [2]xsh_order_list_save() at xsh_data_order.c:841
> [ ERROR ] Test-XSH_DETECT_CONTINUUM:  
> [ ERROR ] Test-XSH_DETECT_CONTINUUM: Illegal output
> [ ERROR ] Test-XSH_DETECT_CONTINUUM:  in [1]main() at test-xsh_detect_continuum.c:200
> [ ERROR ] Test-XSH_DETECT_CONTINUUM:  


The reason for this behaviour is incorrect usage of sprintf function,
in file xsh/xsh_data_order.c.
Test test_xsh_correl_gaussians fails because of uninitialized variable norm,
in file tests/test-xsh_correl_gaussians.c.

Patch adapt-sprintf-usage.patch contains previously described changes.
With these changes I was able to successfully build cpl-plugin-xshoo 
for mips and mipsel.

On armel, armhf and powerpc build also fails on
test_xsh_detect_continuum and test_xsh_flux_conservation tests,
so I believe that this patch could resolve issues for these archs as well.


Could you please consider including this patch?


Best Regards,
Dejan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: adapt-sprintf-usage.patch
Type: text/x-patch
Size: 5823 bytes
Desc: adapt-sprintf-usage.patch
URL: <http://lists.alioth.debian.org/pipermail/debian-astro-maintainers/attachments/20140606/3c6a7f0f/attachment.bin>