[Debian-astro-maintainers] Bug#786715: stellarium: Uses private copies of external headers

[Tomasz Buchert]

On 02/06/15 18:29, Sune Vuorela wrote:
> On Tuesday 02 June 2015 10:07:30 Thibaut Paumard wrote:
>
> > Quoting: https://www.debian.org/Bugs/Developer.en.html#severities
> >
> > serious
> >     is a severe violation of Debian policy (roughly, it violates a
> >     "must" or "required" directive), or, in the package maintainer's or
> >     release manager's opinion, makes the package unsuitable for release.
> >
> > In this instance, I fail to see which section of the Policy is being
> > violated.
>
> I'm maintainer of Qt. that should be sufficient. This issue makes it
> approximately 25% more work every time we introduce a new Qt version to the
> archive, because it relies on Qt *internals*, and packages that does that just
> requires more work for the Qt maintainers on each new update. And there is no
> reason for stellarium to actually give the Qt maintainers that extra work.
>
> So please, pretty please, let's get it fixed fast.
>
> /Sune

Hi Sune,
will this [1] do the trick?

  * I've imported the upstream patch
  * changed includes which seemed like hooking into private API into
    public headers
  * I also verified that the resulting file does not link to symbols
    that are private; you may look at [2] where I extract the symbols
    (pax-utils are necessary) and list them; QArrayData and QListData
    look suspicious, but as far I can tell, they are part of stable, yet
    non-public API

Having this patch, we (or upstream) can think of a better solution.

Tomasz

[1] http://anonscm.debian.org/cgit/debian-astro/packages/stellarium.git/log/?h=bug-786715/fix
[2] http://anonscm.debian.org/cgit/debian-astro/packages/stellarium.git/log/?h=bug-786715/sandbox
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-astro-maintainers/attachments/20150603/c34a7b10/attachment.sig>