[Debian-astro-maintainers] Bug#811753: saods9: FTBFS with GCC 6: narrowing conversion

[Martin Michlmayr]

Package: saods9
Version: 7.4+repack-1
Severity: important
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-6 gcc-6-narrowing

This package fails to build with GCC 6.  GCC 6 has not been released
yet, but it's expected that GCC 6 will become the default compiler for
stretch.

Note that only the first error is reported; there might be more.  You
can find a snapshot of GCC 6 in experimental.  To build with GCC 6,
you can set CC=gcc-6 CXX=g++-6 explicitly.

You may be able to find out more about this issue at
https://gcc.gnu.org/gcc-6/changes.html

> sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
...
> gcc -DPACKAGE_NAME=\"tksao\" -DPACKAGE_TARNAME=\"tksao\" -DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"tksao\ 1.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DBUILD_tksao=/\*\*/ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIMITS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SHM_H=1 -DUSE_THREAD_ALLOC=1 -D_REENTRANT=1 -D_THREAD_SAFE=1 -DTCL_THREADS=1 -DMODULE_SCOPE=extern\ __attribute__\(\(__visibility__\(\"hidden\"\)\)\) -DHAVE_HIDDEN=1 -DHAVE_CAST_TO_UNION=1 -D_LARGEFILE64_SOURCE=1 -DTCL_WIDE_INT_IS_LONG=1 -DUSE_TCL_STUBS=1  -I. -I./colorbar -I./fitsy++ -I./frame -I./list -I./magnifier -I./panner -I./util -I./vector -I./wcssubs -I./widget -I../include -Ifuntools-1.4.5/filter -Ifuntools-1.4.5/fitsy -Ifuntools-1.4.5/util -Iast-8.0.2 -I/usr/include/libxml2 -I"/usr/include/tcl8.6" -I"/usr/include/tcl8.6/tk-private/generic" -I"/usr/include/
> tcl8.6/tk-private/unix" -I"/usr/include/tcl8.6/tk-private/generic/ttk"     -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -pipe -g -Wall -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -c `echo fitsy++/parser.C` -o fitsy++/parser.o
> fitsy++/outsocket.C: In constructor 'OutFitsSocketGZ::OutFitsSocketGZ(int)':
> fitsy++/outsocket.C:64:71: error: narrowing conversion of '139' from 'int' to 'char' inside { } [-Wnarrowing]
>    char header[10] = {0x1f,0x8b,0x08,0x00,0x00,0x00,0x00,0x00,0x00,0x03};
>                                                                        ^
> 
> fitsy++/outfits.C: In member function 'int OutFitsStream::writeSwap(char*, int, int)':
> fitsy++/outfits.C:52:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>    } while (r>0 && rr<size);
>                    ~~^~~~~
> 
> Makefile:396: recipe for target 'fitsy++/outsocket.o' failed

-- 
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise