[Debian-astro-maintainers] Bug#871509: hides build failures: mklib exit code not checked

[Helmut Grohne]

Source: xpa
Version: 2.1.18-1
Tags: upstream
Severity: serious
Justification: policy 4.6

The shlib target in xpa's Makefile.in says:

| 		./mklib -ldflags "$(LDFLAGS)" -o $(PACKAGE) `LC_ALL=C ls lib$(PACKAGE).tmp/*.o`; \
| 		rm -rf lib$(PACKAGE).tmp)

If mklib fails, the error is ignored and the build continues potentially
creating broken packages. This violates the Debian policy section 4.6. I
learned it the hard way as mklib did fail here (though that's not a
fault of xpa).

Helmut