[Debian-astro-maintainers] Bug#873690: ginga: don't hard-code python versions in debian/rules

Steve Langasek steve.langasek at canonical.com
Wed Aug 30 07:13:14 UTC 2017


Package: ginga
Version: 2.6.5-1
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu artful ubuntu-patch

ginga sets PYTHONPATH in order to call the program locally for help2man. 
But even though debian/rules uses py3versions and already has a $(PYTHON3)
variable available for use, the PYTHONPATH is hard-coding python3.5.

This will become a build failure when Debian transitions to python3.6, which
is due to happen sometime soon this cycle.

Attached is a patch that fixes this latent bug.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru ginga-2.6.5/debian/rules ginga-2.6.5/debian/rules
--- ginga-2.6.5/debian/rules	2016-11-17 03:26:16.000000000 -0800
+++ ginga-2.6.5/debian/rules	2017-08-30 00:05:08.000000000 -0700
@@ -13,7 +13,7 @@
 	rm -rf debian/python3-ginga/usr/bin debian/python*-ginga/usr/lib/python*/dist-packages/ginga/examples
 
 override_dh_installman:
-	PYTHONPATH=debian/python3-ginga/usr/lib/python3.5/dist-packages/ help2man -N -n "Astronomical FITS Image Viewer" debian/ginga/usr/bin/ginga > ginga.1
-	PYTHONPATH=debian/python3-ginga/usr/lib/python3.5/dist-packages/ help2man -N -n "Ginga Remote Control client" debian/ginga/usr/bin/ggrc > ggrc.1
+	PYTHONPATH=debian/python3-ginga/usr/lib/python$(PYTHON3)/dist-packages/ help2man -N -n "Astronomical FITS Image Viewer" debian/ginga/usr/bin/ginga > ginga.1
+	PYTHONPATH=debian/python3-ginga/usr/lib/python$(PYTHON3)/dist-packages/ help2man -N -n "Ginga Remote Control client" debian/ginga/usr/bin/ggrc > ggrc.1
 	dh_installman
 


More information about the Debian-astro-maintainers mailing list