[Debian-astro-maintainers] Bug#890314: cpl-plugin-visir: please make the build reproducible

[Chris Lamb]

Source: cpl-plugin-visir
Version: 4.3.3+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that cpl-plugin-visir could not be built reproducibly.

I think the index-based sorting is broken for some reason (probably
not reliably sorted prior to this) so moving to name-based in the
attached patch.


 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/create_sphinx.py	2018-02-13 09:42:43.632869456 +0000
--- b/debian/create_sphinx.py	2018-02-13 10:31:36.269867461 +0000
@@ -142,8 +142,7 @@
 oca = file(os.path.join("calib", "gasgano", "config", pipeline + ".oca")).read()
 oca = oca[oca.find("action"):]
 recipes_oca = [recipe for recipe in recipes if recipe.__name__ in oca]
-index = [ oca.find(recipe.__name__) for recipe in recipes_oca ]
-recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
+recipes_oca.sort(key = lambda x: x.__name__)
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
 recipes_x.sort(key = lambda x: x.__name__)