[Debian-astro-maintainers] Bug#893407: ftools-fv: Consider migration to Itcl 4
Sergei Golovan
sgolovan at nes.ru
Sun Mar 18 17:45:09 UTC 2018
Source: ftools-fv
Version: 5.4+dfsg-2
Severity: wishlist
Tags: patch
Dear Maintainer,
I would like to switch the iwidgets4 package to Itcl/Itk 4 (currently they are
using version 3). I've already uploaded iwidgets4 4.1.0-2 which depend on
tcl-itcl4 and tk-itk4 into experimental for testing. And I'd like you to test
fvtools-fv with it.
Attached is a minimal patch which makes ftools-fv building and runnig. Can you
upload fvtools-fv to experimental as well, test it and report any bugs in Itcl/Ik 4
you'd found in this setup? (One bug is already found and reported upstream,
its workaround is include into the patch).
The patch looks like NMU, but I don't plan to do the upload. Though I'd like
to switch Iwidgets to Itcl/Itk 4 before the buster's release. Can you help me
with it?
-- System Information:
Debian Release: 9.4
APT prefers stable-debug
APT policy: (500, 'stable-debug'), (500, 'proposed-updates'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental'), (1, 'unstable'), (1, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.14.0-0.bpo.3-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-- no debconf information
-------------- next part --------------
diff -Nru ftools-fv-5.4+dfsg/debian/changelog ftools-fv-5.4+dfsg/debian/changelog
--- ftools-fv-5.4+dfsg/debian/changelog 2016-09-13 14:25:06.000000000 +0300
+++ ftools-fv-5.4+dfsg/debian/changelog 2018-03-18 17:26:22.000000000 +0300
@@ -1,3 +1,13 @@
+ftools-fv (5.4+dfsg-2.1) experimental; urgency=low
+
+ * Non-maintainer upload.
+ * Relax the Itcl version requirement to allow version 4 to be loaded.
+ * Depend on Itcl and Itk indirectly through Iwidgets.
+ * Remove a call to [fvPref save] during initial objects creation because
+ it causes crash with Itcl 4.
+
+ -- Sergei Golovan <sgolovan at debian.org> Sun, 18 Mar 2018 17:26:22 +0300
+
ftools-fv (5.4+dfsg-2) unstable; urgency=low
* Update standards-version to 3.9.8 (no changes)
diff -Nru ftools-fv-5.4+dfsg/debian/control ftools-fv-5.4+dfsg/debian/control
--- ftools-fv-5.4+dfsg/debian/control 2016-09-13 14:24:45.000000000 +0300
+++ ftools-fv-5.4+dfsg/debian/control 2018-03-18 17:26:22.000000000 +0300
@@ -16,7 +16,7 @@
Package: ftools-fv
Architecture: all
-Depends: ftools-pow, itcl3, itk3, iwidgets4, ${misc:Depends}, ${shlibs:Depends}
+Depends: ftools-pow, iwidgets4, ${misc:Depends}, ${shlibs:Depends}
Conflicts: fv
Replaces: fv
Suggests: saods9, xpa-tools
@@ -33,9 +33,7 @@
Package: ftools-pow
Architecture: any
Multi-Arch: same
-Depends: itcl3,
- itk3,
- iwidgets4,
+Depends: iwidgets4 (>= 4.1.0-2),
tcl-fitstcl,
tix,
${misc:Depends},
diff -Nru ftools-fv-5.4+dfsg/debian/patches/itcl4.patch ftools-fv-5.4+dfsg/debian/patches/itcl4.patch
--- ftools-fv-5.4+dfsg/debian/patches/itcl4.patch 1970-01-01 03:00:00.000000000 +0300
+++ ftools-fv-5.4+dfsg/debian/patches/itcl4.patch 2018-03-18 17:26:22.000000000 +0300
@@ -0,0 +1,28 @@
+Author: Sergei Golovan
+Description: Patch relaxes the loaded Itcl version. This means
+ that Itcl 4 can be used. Also, it removes a call to [fvPref save]
+ which causes a crach with Itcl 4.
+Bug: https://core.tcl.tk/itcl/tktview?name=15f7db53b9
+
+--- a/ftools/guis/fv/class/fvWinKeeper.tcl
++++ b/ftools/guis/fv/class/fvWinKeeper.tcl
+@@ -148,7 +148,7 @@
+ if { $xpaFlag == "NOT_AVAILABLE" } {
+ # $itk_component(displayFrame) entryconfigure 0 -state disabled
+ set ::fvPref::imgDisplayer "POW"
+- fvPref save
++ #fvPref save
+ }
+ } else {
+ $itk_component(displayFrame) entryconfigure 0 -state normal
+--- a/tcltk/pow/PowInit.c
++++ b/tcltk/pow/PowInit.c
+@@ -108,7 +108,7 @@
+ return TCL_ERROR;
+ }
+
+- Tcl_PkgRequire(interp, "Itcl", "3.0", 0);
++ Tcl_PkgRequire(interp, "Itcl", NULL, 0);
+
+ #if defined(MAC_TCL) && defined(PLUGIN)
+
diff -Nru ftools-fv-5.4+dfsg/debian/patches/series ftools-fv-5.4+dfsg/debian/patches/series
--- ftools-fv-5.4+dfsg/debian/patches/series 2015-09-02 11:22:56.000000000 +0300
+++ ftools-fv-5.4+dfsg/debian/patches/series 2018-03-18 17:26:22.000000000 +0300
@@ -7,3 +7,4 @@
fv_fix_initial_menubar.patch
fv_fix_startup.patch
fvtmp.patch
+itcl4.patch
More information about the Debian-astro-maintainers
mailing list