[Debian-astro-maintainers] Bug#897728: cpl-plugin-sinfo: ftbfs with GCC-8

[Matthias Klose]

Package: src:cpl-plugin-sinfo
Version: 3.1.0+dfsg-1
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-8

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The
severity of this report will be raised before the buster release.

The full build log can be found at:
http://aws-logs.debian.net/2018/05/01/gcc8/cpl-plugin-sinfo_3.1.0+dfsg-1_unstable_gcc8.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 8, either set CC=gcc-8 CXX=g++-8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-8/porting_to.html

[...]
cc1: some warnings being treated as errors
make[4]: *** [Makefile:1011: sinfo_rec_utils.lo] Error 1
make[4]: Leaving directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
make[4]: *** Waiting for unfinished jobs....
make[4]: Entering directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include    -Wdate-time -D_FORTIFY_SOURCE=2  -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c -o sinfo_focus_determination_config.lo sinfo_focus_determination_config.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c sinfo_focus_determination_config.c  -fPIC -DPIC -o .libs/sinfo_focus_determination_config.o
make[4]: Leaving directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
make[4]: Entering directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include    -Wdate-time -D_FORTIFY_SOURCE=2  -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c -o sinfo_lamp_spec_config.lo sinfo_lamp_spec_config.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c sinfo_lamp_spec_config.c  -fPIC -DPIC -o .libs/sinfo_lamp_spec_config.o
make[4]: Leaving directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
make[4]: Entering directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include    -Wdate-time -D_FORTIFY_SOURCE=2  -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c -o sinfo_north_south_test_config.lo sinfo_north_south_test_config.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c sinfo_north_south_test_config.c  -fPIC -DPIC -o .libs/sinfo_north_south_test_config.o
make[4]: Leaving directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
make[4]: Entering directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include    -Wdate-time -D_FORTIFY_SOURCE=2  -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c -o sinfo_distortion_config.lo sinfo_distortion_config.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c sinfo_distortion_config.c  -fPIC -DPIC -o .libs/sinfo_distortion_config.o
make[4]: Leaving directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
make[4]: Entering directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include    -Wdate-time -D_FORTIFY_SOURCE=2  -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c -o sinfo_lamp_flats_config.lo sinfo_lamp_flats_config.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c sinfo_lamp_flats_config.c  -fPIC -DPIC -o .libs/sinfo_lamp_flats_config.o
make[4]: Leaving directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
make[4]: Entering directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include    -Wdate-time -D_FORTIFY_SOURCE=2  -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c -o sinfo_distortion.lo sinfo_distortion.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c sinfo_distortion.c  -fPIC -DPIC -o .libs/sinfo_distortion.o
sinfo_distortion.c: In function 'sinfo_distortion_detect_arcs_new':
sinfo_distortion.c:527:5: warning: 'cpl_mask_closing' is deprecated [-Wdeprecated-declarations]
     cpl_mask_closing(bin_im, filter) ;
     ^~~~~~~~~~~~~~~~
In file included from /usr/include/cpl_image_io.h:35,
                 from /usr/include/cpl_image.h:27,
                 from /usr/include/cpl.h:28,
                 from ./sinfo_cpl_size.h:11,
                 from sinfo_distortion.c:31:
/usr/include/cpl_mask.h:104:16: note: declared here
 cpl_error_code cpl_mask_closing(cpl_mask *,
                ^~~~~~~~~~~~~~~~
make[4]: Leaving directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
make[4]: Entering directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include    -Wdate-time -D_FORTIFY_SOURCE=2  -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c -o sinfo_skycor.lo sinfo_skycor.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../sinfoni -I../irplib -I/usr/include/cpl -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror=implicit-function-declaration -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-builtin -std=c99 -Werror=incompatible-pointer-types -Werror=format -Werror=init-self -Werror=missing-declarations -Werror=missing-format-attribute -Werror=missing-noreturn -Werror=nested-externs -Werror=pointer-arith -Werror=redundant-decls -Werror=sign-compare -Werror=undef -Werror=variadic-macros -Werror=volatile-register-var -Werror=write-strings -Wmissing-prototypes -Wmaybe-uninitialized -fno-common -fstrict-aliasing -c sinfo_skycor.c  -fPIC -DPIC -o .libs/sinfo_skycor.o
make[4]: Leaving directory '/<<BUILDDIR>>/cpl-plugin-sinfo-3.1.0+dfsg/sinfoni'
make[3]: *** [Makefile:1047: all-recursive] Error 1
make[2]: *** [Makefile:528: all-recursive] Error 1
make[1]: *** [Makefile:434: all] Error 2
dh_auto_build: make -j8 -Oline returned exit code 2
make: *** [debian/rules:14: build-arch] Error 25
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2