[Debian-astro-maintainers] Bug#921324: astropy-healpix FTBFS on i386: test filure

[Adrian Bunk]

Source: astropy-healpix
Version: 0.4-4
Severity: serious
Tags: ftbfs patch

https://buildd.debian.org/status/fetch.php?pkg=astropy-healpix&arch=i386&ver=0.4-4&stamp=1548693347&raw=0

...
=================================== FAILURES ===================================
_______________________________ test_boundaries ________________________________

    @given(nside_pow=integers(0, 29), step=integers(1, 10), nest=booleans(),
>          frac=floats(0, 1, allow_nan=False, allow_infinity=False).filter(lambda x: x < 1))

astropy_healpix/tests/test_healpy.py:185: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib/python3/dist-packages/hypothesis/core.py:519: in execute
    result = self.test_runner(data, run)
/usr/lib/python3/dist-packages/hypothesis/executors.py:58: in default_new_style_executor
    return function(data)
/usr/lib/python3/dist-packages/hypothesis/core.py:517: in run
    return test(*args, **kwargs)
astropy_healpix/tests/test_healpy.py:185: in test_boundaries
    frac=floats(0, 1, allow_nan=False, allow_infinity=False).filter(lambda x: x < 1))
/usr/lib/python3/dist-packages/hypothesis/core.py:464: in test
    result = self.test(*args, **kwargs)
astropy_healpix/tests/test_healpy.py:190: in test_boundaries
    b1 = hp_compat.boundaries(nside, pix, step=step, nest=nest)
astropy_healpix/healpy.py:152: in boundaries
    lon, lat = boundaries_lonlat(pix, step, nside, order='nested' if nest else 'ring')
astropy_healpix/core.py:673: in boundaries_lonlat
    lon, lat = healpix_to_lonlat(healpix_index.ravel(), nside, dx.ravel(), dy.ravel(), order=order)
astropy_healpix/core.py:393: in healpix_to_lonlat
    lat = Latitude(lat, unit=u.rad, copy=False)
/usr/lib/python3/dist-packages/astropy/coordinates/angles.py:514: in __new__
    self._validate_angles()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <Latitude [ 0.        , -0.72972766, -1.57079633, -0.72972766] rad>
angles = <Latitude [ 0.        , -0.72972766, -1.57079633, -0.72972766] rad>

    def _validate_angles(self, angles=None):
        """Check that angles are between -90 and 90 degrees.
        If not given, the check is done on the object itself"""
        # Convert the lower and upper bounds to the "native" unit of
        # this angle.  This limits multiplication to two values,
        # rather than the N values in `self.value`.  Also, the
        # comparison is performed on raw arrays, rather than Quantity
        # objects, for speed.
        if angles is None:
            angles = self
        lower = u.degree.to(angles.unit, -90.0)
        upper = u.degree.to(angles.unit, 90.0)
        if np.any(angles.value < lower) or np.any(angles.value > upper):
            raise ValueError('Latitude angle(s) must be within -90 deg <= angle <= 90 deg, '
>                            'got {0}'.format(angles.to(u.degree)))
E           ValueError: Latitude angle(s) must be within -90 deg <= angle <= 90 deg, got [  0.        -41.8103149 -90.        -41.8103149] deg

/usr/lib/python3/dist-packages/astropy/coordinates/angles.py:531: ValueError
---------------------------------- Hypothesis ----------------------------------
Falsifying example: test_boundaries(nside_pow=0, frac=0.6666666666666666, step=1, nest=False)
==================== 1 failed, 124 passed in 24.30 seconds =====================
/usr/lib/python3/dist-packages/astropy/config/configuration.py:536: ConfigurationMissingWarning: Configuration defaults will be used due to FileNotFoundError:2 on None
  warn(ConfigurationMissingWarning(msg))
make[1]: *** [debian/rules:17: test-python3.7] Error 1



Fix:

--- debian/rules.old	2019-02-04 09:12:02.674701984 +0000
+++ debian/rules	2019-02-04 09:13:52.286700939 +0000
@@ -9,6 +9,10 @@
 # Astropy-affiliated packages do.
 export PYBUILD_AFTER_INSTALL := find {destdir} -name '*.c' -delete
 
+ifeq ($(DEB_HOST_ARCH),i386)
+  export DEB_CFLAGS_MAINT_APPEND=-ffloat-store
+endif
+
 %:
 	dh $@ --with python3 --buildsystem=pybuild