[Debian-astro-maintainers] Bug#957545: missfits: ftbfs with GCC-10

[Matthias Klose]

Package: src:missfits
Version: 2.8.0-2
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/missfits_2.8.0-2_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xml.c:142:32: warning: ‘%s’ directive writing up to 511 bytes into a region of size 80 [-Wformat-overflow=]
  142 |         sprintf(x->filename,"%s%s%s",name,prefs.new_suffix,FITS_SUFFIX);
      |                                ^~         ~~~~~~~~~~~~~~~~
In file included from /usr/include/stdio.h:867,
                 from xml.c:35:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output 6 or more bytes (assuming 517) into a destination of size 80
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xml.c: In function ‘write_xml_meta’:
xml.c:435:35: warning: ‘%02d’ directive writing between 2 and 11 bytes into a region of size between 0 and 7 [-Wformat-overflow=]
  435 |     sprintf(prefs.sdate_end,"%04d-%02d-%02d",
      |                                   ^~~~
xml.c:435:29: note: directive argument in the range [-2147483647, 2147483647]
  435 |     sprintf(prefs.sdate_end,"%04d-%02d-%02d",
      |                             ^~~~~~~~~~~~~~~~
In file included from /usr/include/stdio.h:867,
                 from xml.c:35:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 11 and 36 bytes into a destination of size 12
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -Wl,-z,relro -o missfits custom.o file.o fitswcs.o main.o makeit.o prefs.o process.o xml.o ../src/fits/libfits.a ../src/wcs/libwcs_c.a -lm 
/usr/bin/ld: file.o:./src/prefs.h:87: multiple definition of `prefs'; custom.o:./src/prefs.h:87: first defined here
/usr/bin/ld: file.o:./src/globals.h:33: multiple definition of `gstr'; custom.o:./src/globals.h:33: first defined here
/usr/bin/ld: file.o:./src/fits/fitscat.h:336: multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: fitswcs.o:(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: main.o:./src/prefs.h:87: multiple definition of `prefs'; custom.o:./src/prefs.h:87: first defined here
/usr/bin/ld: main.o:./src/fits/fitscat.h:336: multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: main.o:./src/globals.h:33: multiple definition of `gstr'; custom.o:./src/globals.h:33: first defined here
/usr/bin/ld: makeit.o:./src/prefs.h:87: multiple definition of `prefs'; custom.o:./src/prefs.h:87: first defined here
/usr/bin/ld: makeit.o:./src/globals.h:33: multiple definition of `gstr'; custom.o:./src/globals.h:33: first defined here
/usr/bin/ld: makeit.o:./src/fits/fitscat.h:336: multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: prefs.o:./src/prefs.h:87: multiple definition of `prefs'; custom.o:./src/prefs.h:87: first defined here
/usr/bin/ld: prefs.o:./src/fits/fitscat.h:336: multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: prefs.o:./src/globals.h:33: multiple definition of `gstr'; custom.o:./src/globals.h:33: first defined here
/usr/bin/ld: process.o:./src/prefs.h:87: multiple definition of `prefs'; custom.o:./src/prefs.h:87: first defined here
/usr/bin/ld: process.o:./src/fits/fitscat.h:336: multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: process.o:./src/globals.h:33: multiple definition of `gstr'; custom.o:./src/globals.h:33: first defined here
/usr/bin/ld: xml.o:./src/prefs.h:87: multiple definition of `prefs'; custom.o:./src/prefs.h:87: first defined here
/usr/bin/ld: xml.o:./src/fits/fitscat.h:336: multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: xml.o:./src/globals.h:33: multiple definition of `gstr'; custom.o:./src/globals.h:33: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitsbody.o):(.bss+0x20): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitscat.o):(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitscheck.o):(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitscleanup.o):(.bss+0x18): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitshead.o):(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitsmisc.o):(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitsread.o):(.bss+0xb40): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitstab.o):(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitsutil.o):(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitswrite.o):(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
/usr/bin/ld: ../src/fits/libfits.a(fitskey.o):(.bss+0x0): multiple definition of `bswapflag'; custom.o:./src/fits/fitscat.h:336: first defined here
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:422: missfits] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[3]: *** [Makefile:466: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:455: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:373: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:8: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2