[Debian-astro-maintainers] Bug#984164: gyoto: ftbfs with GCC-11

[Matthias Klose]

Package: src:gyoto
Version: 1.4.4-3
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/gyoto_1.4.4-3_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
  667 |       data->binspectrum=curvect;
      |       ^~~~
In file included from /usr/include/c++/11/vector:69,
                 from ../include/GyotoDefs.h:29,
                 from gyoto.C:21:
/usr/include/c++/11/bits/range_access.h:318:5: note: candidates are: ‘template<class _Tp> constexpr const _Tp* std::data(std::initializer_list<_Tp>)’
  318 |     data(initializer_list<_Tp> __il) noexcept
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:309:5: note:                 ‘template<class _Tp, long unsigned int _Nm> constexpr _Tp* std::data(_Tp (&)[_Nm])’
  309 |     data(_Tp (&__array)[_Nm]) noexcept
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:299:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(const _Container&)’
  299 |     data(const _Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:289:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(_Container&)’
  289 |     data(_Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
gyoto.C:64:42: note:                 ‘Gyoto::SmartPointer<Gyoto::Astrobj::Properties> data’
   64 | static SmartPointer<Astrobj::Properties> data = NULL;
      |                                          ^~~~
gyoto.C:670:7: error: reference to ‘data’ is ambiguous
  670 |       data->offset=int(offset);
      |       ^~~~
In file included from /usr/include/c++/11/vector:69,
                 from ../include/GyotoDefs.h:29,
                 from gyoto.C:21:
/usr/include/c++/11/bits/range_access.h:318:5: note: candidates are: ‘template<class _Tp> constexpr const _Tp* std::data(std::initializer_list<_Tp>)’
  318 |     data(initializer_list<_Tp> __il) noexcept
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:309:5: note:                 ‘template<class _Tp, long unsigned int _Nm> constexpr _Tp* std::data(_Tp (&)[_Nm])’
  309 |     data(_Tp (&__array)[_Nm]) noexcept
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:299:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(const _Container&)’
  299 |     data(const _Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:289:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(_Container&)’
  289 |     data(_Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
gyoto.C:64:42: note:                 ‘Gyoto::SmartPointer<Gyoto::Astrobj::Properties> data’
   64 | static SmartPointer<Astrobj::Properties> data = NULL;
      |                                          ^~~~
gyoto.C:691:31: error: reference to ‘data’ is ambiguous
  691 |     scenery -> rayTrace(grid, data, ipctdims[0]?impactcoords:NULL);
      |                               ^~~~
In file included from /usr/include/c++/11/vector:69,
                 from ../include/GyotoDefs.h:29,
                 from gyoto.C:21:
/usr/include/c++/11/bits/range_access.h:318:5: note: candidates are: ‘template<class _Tp> constexpr const _Tp* std::data(std::initializer_list<_Tp>)’
  318 |     data(initializer_list<_Tp> __il) noexcept
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:309:5: note:                 ‘template<class _Tp, long unsigned int _Nm> constexpr _Tp* std::data(_Tp (&)[_Nm])’
  309 |     data(_Tp (&__array)[_Nm]) noexcept
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:299:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(const _Container&)’
  299 |     data(const _Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
/usr/include/c++/11/bits/range_access.h:289:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(_Container&)’
  289 |     data(_Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
gyoto.C:64:42: note:                 ‘Gyoto::SmartPointer<Gyoto::Astrobj::Properties> data’
   64 | static SmartPointer<Astrobj::Properties> data = NULL;
      |                                          ^~~~
make[3]: *** [Makefile:603: gyoto-gyoto.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/bin'
make[2]: *** [Makefile:963: bin] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules:60: override_dh_auto_build-arch] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:39: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2