[Debian-astro-maintainers] Bug#994786: spectral-cube: autopkgtest needs update for new version of radio-beam: warning message changed

[Paul Gevers]

Source: spectral-cube
Version: 0.5.0-3
Severity: serious
X-Debbugs-CC: debian-ci at lists.debian.org, radio-beam at packages.debian.org
Tags: sid bookworm
User: debian-ci at lists.debian.org
Usertags: needs-update
Control: affects -1 src:radio-beam

Dear maintainer(s),

With a recent upload of radio-beam the autopkgtest of spectral-cube
fails in testing when that autopkgtest is run with the binary packages
of radio-beam from unstable. It passes when run with only packages from
testing. In tabular form:

                       pass            fail
radio-beam             from testing    0.3.3-1
spectral-cube          from testing    0.5.0-3
all others             from testing    from testing

I copied some of the output at the bottom of this report. It seems to me
that there was an *addition* warning raised and thus the check fails.

Currently this regression is blocking the migration of radio-beam to
testing [1]. Of course, radio-beam shouldn't just break your autopkgtest
(or even worse, your package), but it seems to me that the change in
radio-beam was intended and your package needs to update to the new
situation.

If this is a real problem in your package (and not only in your
autopkgtest), the right binary package(s) from radio-beam should really
add a versioned Breaks on the unfixed version of (one of your)
package(s). Note: the Breaks is nice even if the issue is only in the
autopkgtest as it helps the migration software to figure out the right
versions to combine in the tests.

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[0] You can see what packages were added from the second line of the log
file quoted below. The migration software adds source package from
unstable to the list if they are needed to install packages from
radio-beam/0.3.3-1. I.e. due to versioned dependencies or breaks/conflicts.
[1] https://qa.debian.org/excuses.php?package=radio-beam

https://ci.debian.net/data/autopkgtest/testing/amd64/s/spectral-cube/15365768/log.gz

=================================== FAILURES
===================================
___________________________ test_parallel_bad_params
___________________________

data_adv =
PosixPath('/tmp/pytest-of-debci/pytest-0/test_parallel_bad_params0/adv.fits')

    @pytest.mark.skipif('not scipyOK')
    def test_parallel_bad_params(data_adv):

        # This function only makes sense for the plain SpectralCube class

        cube, data = cube_and_raw(data_adv, use_dask=False)

        with pytest.raises(ValueError,
                           match=("parallel execution was not requested,
but "
                                  "multiple cores were: these are
incompatible "
                                  "options.  Either specify num_cores=1 or "
                                  "parallel=True")):
            cube.spectral_smooth_median(3, num_cores=2, parallel=False,
                                        update_function=update_function)

        with warnings.catch_warnings(record=True) as wrn:
            cube.spectral_smooth_median(3, num_cores=1, parallel=True,
                                        update_function=update_function)

>       assert ("parallel=True was specified but num_cores=1. "
                "Joblib will be used to run the task with a "
                "single thread.") in str(wrn[-1].message)
E       assert 'parallel=True was specified but num_cores=1. Joblib will
be used to run the task with a single thread.' in "'datfix' made the
change 'Set MJD-OBS to 50982.687794 from DATE-OBS'."
E        +  where "'datfix' made the change 'Set MJD-OBS to 50982.687794
from DATE-OBS'." = str(FITSFixedWarning("'datfix' made the change 'Set
MJD-OBS to 50982.687794 from DATE-OBS'."))
E        +    where FITSFixedWarning("'datfix' made the change 'Set
MJD-OBS to 50982.687794 from DATE-OBS'.") = <warnings.WarningMessage
object at 0x7f90881fff70>.message

/usr/lib/python3/dist-packages/spectral_cube/tests/test_spectral_cube.py:2279:
AssertionError

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/debian-astro-maintainers/attachments/20210920/8ff5d0e4/attachment-0001.sig>