[Debian-astro-maintainers] Bug#1026630: indi-gphoto: FTBFS: gphoto_ccd.h:101:14: error: ‘void GPhotoCCD::addFITSKeywords(fitsfile*, INDI::CCDChip*) ’ marked ‘override’, but does not override

[Lucas Nussbaum]

Source: indi-gphoto
Version: 3.0+20220611124727-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20221220 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> /usr/bin/c++  -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/<<PKGBUILDDIR>> -I/usr/include/libindi -I/usr/include/libraw -I/usr/include/libusb-1.0 -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIE -O1 -Wa,--noexecstack  -Wall -Wextra -Wno-unused-but-set-variable -Wno-format-truncation -g -fPIE -std=gnu++14 -Wno-deprecated-declarations -MD -MT CMakeFiles/indi_gphoto_ccd.dir/gphoto_readimage.cpp.o -MF CMakeFiles/indi_gphoto_ccd.dir/gphoto_readimage.cpp.o.d -o CMakeFiles/indi_gphoto_ccd.dir/gphoto_readimage.cpp.o -c /<<PKGBUILDDIR>>/gphoto_readimage.cpp
> In file included from /<<PKGBUILDDIR>>/gphoto_ccd.cpp:23:
> /<<PKGBUILDDIR>>/gphoto_ccd.h:101:14: error: ‘void GPhotoCCD::addFITSKeywords(fitsfile*, INDI::CCDChip*)’ marked ‘override’, but does not override
>   101 |         void addFITSKeywords(fitsfile * fptr, INDI::CCDChip * targetChip) override;
>       |              ^~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/gphoto_ccd.cpp: In member function ‘void GPhotoCCD::addFITSKeywords(fitsfile*, INDI::CCDChip*)’:
> /<<PKGBUILDDIR>>/gphoto_ccd.cpp:2019:31: error: no matching function for call to ‘GPhotoCCD::addFITSKeywords(fitsfile*&, INDI::CCDChip*&)’
>  2019 |     INDI::CCD::addFITSKeywords(fptr, targetChip);
>       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
> In file included from /<<PKGBUILDDIR>>/gphoto_ccd.h:27:
> /usr/include/libindi/indiccd.h:508:22: note: candidate: ‘virtual void INDI::CCD::addFITSKeywords(INDI::CCDChip*)’
>   508 |         virtual void addFITSKeywords(CCDChip * targetChip);
>       |                      ^~~~~~~~~~~~~~~
> /usr/include/libindi/indiccd.h:508:22: note:   candidate expects 1 argument, 2 provided
> make[3]: *** [CMakeFiles/indi_gphoto_ccd.dir/build.make:79: CMakeFiles/indi_gphoto_ccd.dir/gphoto_ccd.cpp.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2022/12/20/indi-gphoto_3.0+20220611124727-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20221220;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20221220&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.