[Debian-astro-maintainers] Bug#1043608: astropy-helpers: Fails to build source after successful build

[Lucas Nussbaum]

Source: astropy-helpers
Version: 4.0.1-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package astropy-helpers
> dpkg-buildpackage: info: source version 4.0.1-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Ole Streicher <olebole at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --with python3 --buildsystem=pybuild
>    dh_auto_clean -O--buildsystem=pybuild
> I: pybuild base:275: python3.11 setup.py clean 
> /<<PKGBUILDDIR>>/setup.py:14: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
>   if LooseVersion(setuptools.__version__) < '30.3':
> /usr/lib/python3/dist-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
> !!
> 
>         ********************************************************************************
>         The license_file parameter is deprecated, use license_files instead.
> 
>         By 2023-Oct-30, you need to update your project and remove deprecated calls
>         or your builds will no longer be supported.
> 
>         See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
>         ********************************************************************************
> 
> !!
>   parsed = self.parsers.get(option_name, lambda x: x)(value)
> running clean
> removing '/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_astropy-helpers/build' (and everything under it)
> 'build/bdist.linux-x86_64' does not exist -- can't clean it
> 'build/scripts-3.11' does not exist -- can't clean it
>    dh_autoreconf_clean -O--buildsystem=pybuild
>    dh_clean -O--buildsystem=pybuild
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: verifying ./astropy-helpers_4.0.1.orig.tar.gz.asc
> gpgv: Signature made Mon Dec 16 20:26:54 2019 UTC
> gpgv:                using RSA key 0DD00E57D2FBEBA214389EC58BC1E9224F65DAD4
> gpgv: Note: signatures using the SHA1 algorithm are rejected
> gpgv: Can't check signature: Bad public key
> dpkg-source: warning: cannot verify upstream tarball signature for ./astropy-helpers_4.0.1.orig.tar.gz: no acceptable signature found
> dpkg-source: info: building astropy-helpers using existing ./astropy-helpers_4.0.1.orig.tar.gz
> dpkg-source: info: building astropy-helpers using existing ./astropy-helpers_4.0.1.orig.tar.gz.asc
> dpkg-source: warning: ignoring deletion of file astropy_helpers/version.py, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  astropy-helpers-4.0.1/astropy_helpers.egg-info/PKG-INFO
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/astropy-helpers_4.0.1-1.diff.hiM1MJ
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/astropy-helpers_4.0.1-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.