[Debian-astro-maintainers] Bug#1048498: ser-player: Fails to build source after successful build

[Lucas Nussbaum]

Source: ser-player
Version: 1.7.3-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ---------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package ser-player
> dpkg-buildpackage: info: source version 1.7.3-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Ole Streicher <olebole at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -f build/rcc/qrc_images.cpp
> rm -f build/moc/moc_predefs.h
> rm -f build/moc/moc_ser_player.cpp build/moc/moc_image_widget.cpp build/moc/moc_application.cpp build/moc/moc_frame_slider.cpp build/moc/moc_save_frames_dialog.cpp build/moc/moc_save_frames_progress_dialog.cpp build/moc/moc_markers_dialog.cpp build/moc/moc_histogram_thread.cpp build/moc/moc_histogram_dialog.cpp build/moc/moc_header_details_dialog.cpp build/moc/moc_utf8_validator.cpp build/moc/moc_processing_options_dialog.cpp build/moc/moc_icon_groupbox.cpp build/moc/moc_selection_box_dialog.cpp build/moc/moc_playback_controls_widget.cpp build/moc/moc_playback_controls_dialog.cpp
> rm -f build/o/unix/main.o build/o/unix/ser_player.o build/o/unix/pipp_ser.o build/o/unix/pipp_buffer.o build/o/unix/persistent_data.o build/o/unix/pipp_timestamp.o build/o/unix/image_widget.o build/o/unix/application.o build/o/unix/frame_slider.o build/o/unix/save_frames_dialog.o build/o/unix/save_frames_progress_dialog.o build/o/unix/markers_dialog.o build/o/unix/image.o build/o/unix/histogram_thread.o build/o/unix/histogram_dialog.o build/o/unix/pipp_ser_write.o build/o/unix/header_details_dialog.o build/o/unix/utf8_validator.o build/o/unix/processing_options_dialog.o build/o/unix/icon_groupbox.o build/o/unix/gif_write.o build/o/unix/lzw_compressor.o build/o/unix/pipp_avi_write.o build/o/unix/pipp_avi_write_dib.o build/o/unix/selection_box_dialog.o build/o/unix/neuquant.o build/o/unix/playback_controls_widget.o 
> build/o/unix/playback_controls_dialog.o build/o/unix/tiff_write.o build/o/unix/png_write.o build/o/unix/pipp_utf8_linux.o build/o/unix/qrc_images.o build/o/unix/moc_ser_player.o build/o/unix/moc_image_widget.o build/o/unix/moc_application.o build/o/unix/moc_frame_slider.o build/o/unix/moc_save_frames_dialog.o build/o/unix/moc_save_frames_progress_dialog.o build/o/unix/moc_markers_dialog.o build/o/unix/moc_histogram_thread.o build/o/unix/moc_histogram_dialog.o build/o/unix/moc_header_details_dialog.o build/o/unix/moc_utf8_validator.o build/o/unix/moc_processing_options_dialog.o build/o/unix/moc_icon_groupbox.o build/o/unix/moc_selection_box_dialog.o build/o/unix/moc_playback_controls_widget.o build/o/unix/moc_playback_controls_dialog.o
> rm -f *~ core *.core
> rm -f bin/ser-player 
> rm -f .qmake.stash
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building ser-player using existing ./ser-player_1.7.3.orig.tar.bz2
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  ser-player-1.7.3/export_app_version.sh
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/ser-player_1.7.3-2.diff.kNIJig
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/ser-player_1.7.3-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.