[Debian-astro-maintainers] Bug#1050232: pyregion: binary-any FTBFS with recent jdupes

[Aurelien Jarno]

Source: pyregion
Version: 2.1.1-2
Severity: serious
Tags: ftbfs
Justification: fails to build from source

Dear maintainer,

pyregion fails to build from source when building only binary-any and
not binary-all. From my build log on amd64:

| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
|    dh_installdocs -a -O--buildsystem=pybuild
|    dh_sphinxdoc -a -O--buildsystem=pybuild
| dh_sphinxdoc: warning: Sphinx documentation not found
|    dh_installchangelogs -a -O--buildsystem=pybuild
|    dh_python3 -a -O--buildsystem=pybuild
|    dh_installsystemduser -a -O--buildsystem=pybuild
|    dh_perl -a -O--buildsystem=pybuild
|    debian/rules override_dh_link
| make[1]: Entering directory '/<<PKGBUILDDIR>>'
| py3versions: no X-Python3-Version in control file, using supported versions
| jdupes -rl debian/python-pyregion-doc/usr
| 
| could not stat dir debian/python-pyregion-doc/usr
| No duplicates found.
| make[1]: *** [debian/rules:48: override_dh_link] Error 1
| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
| make: *** [debian/rules:13: binary-arch] Error 2
| dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit status 2

A full build log on riscv64 is also available:
https://buildd.debian.org/status/fetch.php?pkg=pyregion&arch=riscv64&ver=2.1.1-2&stamp=1692574703&raw=0

The return value of jdupes changed after bookworm to no longer return
success when the given paths do not exist, which causes this failure in
binary-any builds.

A possible patch is:

--- pyregion-2.1.1/debian/rules
+++ pyregion-2.1.1/debian/rules
@@ -44,6 +44,5 @@
 	dh_auto_build
 	PYTHONPATH=. sphinx-build $(SPHINXOPTS) -N -bhtml docs/ -d debian/doctrees build/html
 
-override_dh_link:
+execute_after_dh_link-indep:
 	jdupes -rl debian/python-pyregion-doc/usr
-	dh_link

Regards
Aurelien