[Debian-astro-maintainers] Bug#1066465: dcraw: FTBFS: fujiturn.c:76:37: error: implicit declaration of function ‘ntohs’ [-Werror=implicit-function-declaration]
Lucas Nussbaum
lucas at debian.org
Wed Mar 13 11:49:15 GMT 2024
Source: dcraw
Version: 9.28-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> gcc -DPACKAGE_NAME=\"dcraw\" -DPACKAGE_TARNAME=\"dcraw\" -DPACKAGE_VERSION=\"9.28\" -DPACKAGE_STRING=\"dcraw\ 9.28\" -DPACKAGE_BUGREPORT=\"hroch at physics.muni.cz\" -DPACKAGE_URL=\"\" -DPACKAGE=\"dcraw\" -DVERSION=\"9.28\" -DHAVE_LIBM=1 -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_JPEGLIB_H=1 -DHAVE_LIBJPEG=1 -DHAVE_LCMS2_H=1 -DHAVE_LIBLCMS2=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O4 -c -o clean_crw.o clean_crw.c
> fujiturn.c: In function ‘main’:
> fujiturn.c:61:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 61 | fread (in, iwide, sizeof *in, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fujiturn.c:78:5: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 78 | fread (in, iwide, sizeof *in, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fujiturn.c: In function ‘main’:
> fujiturn.c:76:37: error: implicit declaration of function ‘ntohs’ [-Werror=implicit-function-declaration]
> 76 | mid[orow*owide+ocol][i] = ntohs(in[icol][i]);
> | ^~~~~
> fujiturn.c:90:28: error: implicit declaration of function ‘htons’ [-Werror=implicit-function-declaration]
> 90 | out[ocol][i] = htons (
> | ^~~~~
> fujiturn.c:61:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 61 | fread (in, iwide, sizeof *in, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fujiturn.c:78:5: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 78 | fread (in, iwide, sizeof *in, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> clean_crw.c: In function ‘main’:
> clean_crw.c:54:5: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 54 | fread (buffer, 1, size, fp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> fuji_green.c: In function ‘read_shorts’:
> fuji_green.c:72:29: error: implicit declaration of function ‘ntohs’ [-Werror=implicit-function-declaration]
> 72 | if ((order == 0x4949) == (ntohs(0x1234) == 0x1234))
> | ^~~~~
> fuji_green.c:73:5: error: implicit declaration of function ‘swab’ [-Werror=implicit-function-declaration]
> 73 | swab (pixel, pixel, count*2);
> | ^~~~
> fuji_green.c: In function ‘write_psd’:
> fuji_green.c:249:11: error: implicit declaration of function ‘htonl’ [-Werror=implicit-function-declaration]
> 249 | hw[0] = htonl(height*2); /* write the header */
> | ^~~~~
> fuji_green.c: In function ‘main’:
> fuji_green.c:307:9: error: implicit declaration of function ‘isatty’ [-Werror=implicit-function-declaration]
> 307 | if (isatty(1)) {
> | ^~~~~~
> fuji_green.c: In function ‘read_shorts’:
> fuji_green.c:71:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 71 | fread (pixel, 2, count, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fuji_green.c: In function ‘parse_tiff’:
> fuji_green.c:140:11: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 140 | fgets (make, 64, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~
> fuji_green.c:143:11: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 143 | fgets (model, 64, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~
> fuji_green.c: In function ‘identify’:
> fuji_green.c:160:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 160 | fread (head, 1, 32, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> parse.c: In function ‘parse_tiff_ifd’:
> parse.c:431:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 431 | fgets (make, slen, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> parse.c:434:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 434 | fgets (model, slen, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> parse.c:437:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 437 | fgets (model2, slen, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O4 -Wl,-z,relro -Wl,-z,now -o dcfujiturn fujiturn.o -llcms2 -ljpeg -lm
> parse.c: In function ‘parse_rollei’:
> parse.c:732:5: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 732 | fgets (line, 128, ifp);
> | ^~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:452: dcfujiturn16-fujiturn.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/dcraw_9.28-3_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
More information about the Debian-astro-maintainers
mailing list