[Debian-astro-maintainers] Bug#1066520: ftools-fv: FTBFS: Visu_tkImgPict.c:1762:9: error: implicit declaration of function ‘_XInitImageFuncPtrs’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: ftools-fv
Version: 5.5.2+dfsg-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -c -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fPIC -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DHAVE_CONNECT=1 -DHAVE_ACCEPT=1 -DHAVE_LIBDL=1 -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_TIME_H=1 -DSTDC_HEADERS=1 -DHAVE_DIRENT_H=1 -DHAVE_FCNTL_H=1 -DHAVE_LIMITS_H=1 -DHAVE_MALLOC_H=1 -DHAVE_STRING_H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_UNISTD_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DRETSIGTYPE=void -DHAVE_STRFTIME=1 -DHAVE_GETCWD=1 -DHAVE_SOCKET=1 -DHAVE_STRCSPN=1 -DHAVE_STRSPN=1 -DHAVE_STRSTR=1 -DHAVE_STRTOD=1 -DHAVE_STRTOL=1 -DVISU_LIBRARY=\"/usr/lib/pow\"  -I/usr/include/tcl -I/usr/include/tcl/tk-private/generic/ -I/usr/include/tcl/tk-private/generic//../unix  Visu_tkImgPict.c
> Visu_tkImgPict.c:57:5: warning: initialization of ‘int (*)(Tcl_Interp *, const char *, int,  Tcl_Obj * const*, const Tk_ImageType *, struct Tk_ImageMaster_ *, void **)’ from incompatible pointer type ‘int (*)(Tcl_Interp *, char *, int,  Tcl_Obj * const*, Tk_ImageType *, struct Tk_ImageMaster_ *, void **)’ [-Wincompatible-pointer-types]
>    57 |     ImgPictCreate,              /* createProc */
>       |     ^~~~~~~~~~~~~
> Visu_tkImgPict.c:57:5: note: (near initialization for ‘tkPictImageType.createProc’)
> Visu_tkImgPict.c: In function ‘ImgPictCmd’:
> Visu_tkImgPict.c:985:24: warning: zero-length gnu_printf format string [-Wformat-zero-length]
>   985 |         sprintf(string,"");
>       |                        ^~
> Visu_tkImgPict.c:1034:24: warning: zero-length gnu_printf format string [-Wformat-zero-length]
>  1034 |         sprintf(string,"");
>       |                        ^~
> Visu_tkImgPict.c: In function ‘ParseSubcommandOptions’:
> Visu_tkImgPict.c:1341:16: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1341 |         option = argv[index];
>       |                ^
> Visu_tkImgPict.c:1501:32: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1501 |                 optPtr->format = argv[index];
>       |                                ^
> Visu_tkImgPict.c: In function ‘ImgPictConfigureInstance’:
> Visu_tkImgPict.c:1762:9: error: implicit declaration of function ‘_XInitImageFuncPtrs’ [-Werror=implicit-function-declaration]
>  1762 |         _XInitImageFuncPtrs(imagePtr);
>       |         ^~~~~~~~~~~~~~~~~~~
> Visu_tkImgPict.c: In function ‘ImgPictSnap2Pict’:
> Visu_tkImgPict.c:2607:37: warning: passing argument 1 of ‘Tk_FindPict’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  2607 |   if ((destHandle = Tk_FindPict(argv[2])) == NULL) {
>       |                                 ~~~~^~~
> In file included from Visu_tkImgPict.c:26:
> tkpict.h:345:40: note: expected ‘char *’ but argument is of type ‘const char *’
>   345 | extern Tk_PictHandle Tk_FindPict(char *imageName);
>       |                                  ~~~~~~^~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:138: Visu_tkImgPict.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/ftools-fv_5.5.2+dfsg-2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.