[Debian-astro-maintainers] Bug#1066526: fitscut: FTBFS: colormap.c:132:27: error: implicit declaration of function ‘malloc’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: fitscut
Version: 1.4.4-5
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wmissing-prototypes  -c -o output_fits.o output_fits.c
> file_check.c: In function ‘check_output_file’:
> file_check.c:219:31: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   219 |                         (void)fgets (response, sizeof (response)-1, stdin);
>       |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> colormap.c: In function ‘get_colormap’:
> colormap.c:132:27: error: implicit declaration of function ‘malloc’ [-Werror=implicit-function-declaration]
>   132 |         CM = (ColorMap *) malloc (sizeof (ColorMap));
>       |                           ^~~~~~
> colormap.c:43:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’
>    42 | #include "util.h"
>   +++ |+#include <stdlib.h>
>    43 | 
> colormap.c:132:27: warning: incompatible implicit declaration of built-in function ‘malloc’ [-Wbuiltin-declaration-mismatch]
>   132 |         CM = (ColorMap *) malloc (sizeof (ColorMap));
>       |                           ^~~~~~
> colormap.c:132:27: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’
> colormap.c: In function ‘get_png_palette’:
> colormap.c:179:33: warning: incompatible implicit declaration of built-in function ‘malloc’ [-Wbuiltin-declaration-mismatch]
>   179 |         palette = (png_color *) malloc (sizeof (png_color) * nvals);
>       |                                 ^~~~~~
> colormap.c:179:33: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’
> image_scale.c: In function ‘log_image’:
> image_scale.c:216:15: warning: variable ‘user_threshold’ set but not used [-Wunused-but-set-variable]
>   216 |         float user_threshold;
>       |               ^~~~~~~~~~~~~~
> image_scale.c:215:15: warning: variable ‘threshold’ set but not used [-Wunused-but-set-variable]
>   215 |         float threshold;
>       |               ^~~~~~~~~
> image_scale.c: In function ‘sqrt_image’:
> image_scale.c:257:15: warning: variable ‘threshold’ set but not used [-Wunused-but-set-variable]
>   257 |         float threshold;
>       |               ^~~~~~~~~
> output_fits.c: In function ‘fitscut_write_primary’:
> output_fits.c:72:14: warning: variable ‘nelements’ set but not used [-Wunused-but-set-variable]
>    72 |         long nelements;
>       |              ^~~~~~~~~
> output_fits.c:70:14: warning: variable ‘fpixel’ set but not used [-Wunused-but-set-variable]
>    70 |         long fpixel[3];
>       |              ^~~~~~
> cc1: some warnings being treated as errors
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wmissing-prototypes  -c -o output_jpg.o output_jpg.c
> make[2]: *** [Makefile:482: colormap.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/fitscut_1.4.4-5_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.