[Debian-astro-maintainers] Bug#1018675: yt: patch for nose style tests failing autopkgtest

[Chris Peterson]

Package: yt
Version: 4.3.0-1
Followup-For: Bug #1018675
X-Debbugs-Cc: chris.peterson at canonical.com
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu oracular ubuntu-patch
Control: tags -1 patch




*** /tmp/tmpv4mie8nf/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

The nose style tests have been fixed upstream but have yet to be updated
in the packaging. I applied the following patch in Ubuntu to just fix
the ones causing the autopkgtests to fail. It can be dropped once the new
upstream version has been uploaded.

  * d/p/test-alt-ray-tracers-pytest-module-funcs.patch (LP: #2068046)
    - Update test module for Pytest 8 compatibility


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers oracular
  APT policy: (500, 'oracular'), (100, 'oracular-proposed')
Architecture: amd64 (x86_64)

Kernel: Linux 6.8.0-31-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru yt-4.3.0/debian/patches/series yt-4.3.0/debian/patches/series
--- yt-4.3.0/debian/patches/series	2023-12-26 12:02:21.000000000 -0800
+++ yt-4.3.0/debian/patches/series	2024-06-04 10:21:31.000000000 -0700
@@ -9,3 +9,4 @@
 Ignore-invalid-value-warnings-which-may-appear-on-mipsel.patch
 Skip-test-that-leads-to-a-mem-alloc-error-on-mipsel.patch
 TST-fix-an-incompatibility-with-unyt-3.0-amu_cgs-doesn-t-.patch
+test-alt-ray-tracers-pytest-module-funcs.patch
diff -Nru yt-4.3.0/debian/patches/test-alt-ray-tracers-pytest-module-funcs.patch yt-4.3.0/debian/patches/test-alt-ray-tracers-pytest-module-funcs.patch
--- yt-4.3.0/debian/patches/test-alt-ray-tracers-pytest-module-funcs.patch	1969-12-31 16:00:00.000000000 -0800
+++ yt-4.3.0/debian/patches/test-alt-ray-tracers-pytest-module-funcs.patch	2024-06-04 10:45:13.000000000 -0700
@@ -0,0 +1,32 @@
+Description: update yt/u/l/t/test_alt_ray_tracers.py for pytest 8
+ Update the yt/utilities/lib/tests/test_alt_ray_tracers.py module
+ for compatibility with pytest 8, which dropped support for nose
+ style tests. This change is a subset of the larger changes made
+ upstream and can be dropped in 4.3.1.
+Author: Chris Peterson <chris.peterson at canonical.com>
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/yt/+bug/2068046
+Forwarded: not-needed
+Applied-Upstream: https://github.com/yt-project/yt/commit/a6e392ea199593511a43703256419d21e7e3c8bc
+Last-Update: 2024-06-04
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/yt/utilities/lib/tests/test_alt_ray_tracers.py
++++ b/yt/utilities/lib/tests/test_alt_ray_tracers.py
+@@ -9,7 +9,7 @@
+ old_settings = None
+ 
+ 
+-def setup():
++def setup_module():
+     # set up some sample cylindrical grid data, radiating out from center
+     global left_grid, right_grid, amr_levels, center_grid, data, old_settings
+     old_settings = np.geterr()
+@@ -23,7 +23,7 @@
+     data = np.cos(np.sqrt(np.sum(center_grid[:, :2] ** 2, axis=1))) ** 2  # cos^2
+ 
+ 
+-def teardown():
++def teardown_module():
+     np.seterr(**old_settings)
+ 
+