[Debian-astro-maintainers] Bug#1075095: iraf-fitsutil: ftbfs with GCC-14

[Matthias Klose]

Package: src:iraf-fitsutil
Version: 2018.07.06-8
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/iraf-fitsutil_2018.07.06-8_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
kwdb.c:208:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  208 | kwdb_Len (kwdb)
      | ^~~~~~~~
kwdb.c:220:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  220 | kwdb_AddEntry (kwdb, keyword, value, type, comment)
      | ^~~~~~~~~~~~~
kwdb.c:282:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  282 | kwdb_Lookup (kwdb, keyword, instance)
      | ^~~~~~~~~~~
kwdb.c:327:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  327 | kwdb_SetValue (kwdb, keyword, value)
      | ^~~~~~~~~~~~~
kwdb.c:356:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  356 | kwdb_SetComment (kwdb, keyword, comment)
      | ^~~~~~~~~~~~~~~
kwdb.c:406:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  406 | kwdb_SetType (kwdb, keyword, type)
      | ^~~~~~~~~~~~
kwdb.c:455:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  455 | kwdb_Head (kwdb)
      | ^~~~~~~~~
kwdb.c:466:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  466 | kwdb_Tail (kwdb)
      | ^~~~~~~~~
kwdb.c:478:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  478 | kwdb_Next (kwdb, ep)
      | ^~~~~~~~~
kwdb.c:493:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  493 | kwdb_DeleteEntry (kwdb, ep)
      | ^~~~~~~~~~~~~~~~
kwdb.c:551:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  551 | kwdb_RenameEntry (kwdb, ep, newname)
      | ^~~~~~~~~~~~~~~~
kwdb.c:601:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  601 | kwdb_CopyEntry (kwdb, o_kwdb, o_ep, newname)
      | ^~~~~~~~~~~~~~
kwdb.c:628:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  628 | kwdb_GetEntry (kwdb, ep, keyword, value, type, comment)
      | ^~~~~~~~~~~~~
kwdb.c:729:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  729 | kwdb_ReadFITS (kwdb, fd, maxcards, nblank)
      | ^~~~~~~~~~~~~
kwdb.c:856:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  856 | kwdb_UpdateFITS (kwdb, filename, update, extend, npad)
      | ^~~~~~~~~~~~~~~
kwdb.c:981:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  981 | kwdb_WriteFITS (kwdb, fd)
      | ^~~~~~~~~~~~~~
kwdb.c:1064:1: error: return type defaults to ‘int’ [-Wimplicit-int]
 1064 | kwdb_SetIO (kwdb, readfcn, writefcn)
      | ^~~~~~~~~~
kwdb.c:1064:1: warning: conflicting types for ‘kwdb_SetIO’
In file included from kwdb.c:7:
kwdb.h:74:9: note: previous declaration of ‘kwdb_SetIO’ with type ‘void(KWDB *, ssize_t (*)(), ssize_t (*)())’ {aka ‘void(struct kwdb *, long int (*)(), long int (*)())’}
   74 | void    kwdb_SetIO (register KWDB *kwdb,
      |         ^~~~~~~~~~
kwdb.c: In function ‘kwdb_SetIO’:
kwdb.c:1070:18: error: assignment to ‘ssize_t (*)()’ {aka ‘long int (*)()’} from incompatible pointer type ‘int (*)()’ [-Wincompatible-pointer-types]
 1070 |         db->read = readfcn;
      |                  ^
kwdb.c:1071:19: error: assignment to ‘ssize_t (*)()’ {aka ‘long int (*)()’} from incompatible pointer type ‘int (*)()’ [-Wincompatible-pointer-types]
 1071 |         db->write = writefcn;
      |                   ^
src/mkpkg:26: error: Command 'gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c fgwrite.c fgread.c sum32.c checksum.c kwdb.c' returned error
mkpkg[1]: Leaving directory `/<<PKGBUILDDIR>>/src/'
make[1]: *** [debian/rules:16: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:5: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2