[Debian-astro-maintainers] Bug#1075550: tcl-fitstcl: ftbfs with GCC-14

[Matthias Klose]

Package: src:tcl-fitstcl
Version: 2.5-2
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/tcl-fitstcl_2.5-2_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
  722 |                                 CONST84 char ***argvPtr);
fitsIO.c:3572:40: error: passing argument 4 of ‘Tcl_SplitList’ from incompatible pointer type [-Wincompatible-pointer-types]
 3572 |                             &nElement, &cDims )
      |                                        ^~~~~~
      |                                        |
      |                                        char ***
/usr/include/tcl/tclDecls.h:722:49: note: expected ‘const char ***’ but argument is of type ‘char ***’
  722 |                                 CONST84 char ***argvPtr);
fitsIO.c:3607:66: error: passing argument 4 of ‘Tcl_SplitList’ from incompatible pointer type [-Wincompatible-pointer-types]
 3607 |          if ( Tcl_SplitList(curFile->interp, argv[4], &nElement, &cPost )
      |                                                                  ^~~~~~
      |                                                                  |
      |                                                                  char ***
/usr/include/tcl/tclDecls.h:722:49: note: expected ‘const char ***’ but argument is of type ‘char ***’
  722 |                                 CONST84 char ***argvPtr);
fitsCmds.c: In function ‘fitsTcl_load’:
fitsCmds.c:2744:69: error: passing argument 5 of ‘exprGetToPtr’ from incompatible pointer type [-Wincompatible-pointer-types]
 2744 |       if( exprGetToPtr( curFile, argv[3+argOff], nullPtr, numRange, range ) ) {
      |                                                                     ^~~~~
      |                                                                     |
      |                                                                     int *
fitsTclInt.h:412:32: note: expected ‘int (*)[2]’ but argument is of type ‘int *’
  412 |                           int  range[][2]);
      |                           ~~~~~^~~~~~~~~~
fitsCmds.c: In function ‘fitsTcl_sascii’:
fitsCmds.c:2926:60: error: passing argument 4 of ‘Tcl_SplitList’ from incompatible pointer type [-Wincompatible-pointer-types]
 2926 |       if( Tcl_SplitList(curFile->interp, argv[8], &nWdths, &listWid)
      |                                                            ^~~~~~~~
      |                                                            |
      |                                                            char ***
/usr/include/tcl/tclDecls.h:722:49: note: expected ‘const char ***’ but argument is of type ‘char ***’
  722 |                                 CONST84 char ***argvPtr);
fitsCmds.c: In function ‘fitsTcl_sort’:
fitsCmds.c:3149:35: error: passing argument 4 of ‘Tcl_SplitList’ from incompatible pointer type [-Wincompatible-pointer-types]
 3149 |                         &listNum, &listPtr) != TCL_OK ) {
      |                                   ^~~~~~~~
      |                                   |
      |                                   char ***
/usr/include/tcl/tclDecls.h:722:49: note: expected ‘const char ***’ but argument is of type ‘char ***’
  722 |                                 CONST84 char ***argvPtr);
fitsCmds.c: In function ‘fitsTcl_add’:
fitsIO.c: In function ‘fitsSortTable’:
fitsCmds.c:3253:60: error: passing argument 6 of ‘fitsCalculaterngColumn’ from incompatible pointer type [-Wincompatible-pointer-types]
 3253 |                                           argv[5],numRange,range) != TCL_OK ) {
      |                                                            ^~~~~
      |                                                            |
      |                                                            int *
fitsTclInt.h:400:38: note: expected ‘int (*)[2]’ but argument is of type ‘int *’
  400 |                                 int  range[][2]);
      |                                 ~~~~~^~~~~~~~~~
fitsIO.c:7161:58: error: passing argument 2 of ‘Tcl_Merge’ from incompatible pointer type [-Wincompatible-pointer-types]
 7161 |    Tcl_AppendElement(curFile->interp,Tcl_Merge(uniqueNum,rowlist));
      |                                                          ^~~~~~~
      |                                                          |
      |                                                          char **
/usr/include/tcl/tclDecls.h:584:66: note: expected ‘const char * const*’ but argument is of type ‘char **’
  584 | EXTERN char *           Tcl_Merge(int argc, CONST84 char *const *argv);
fitsIO.c:7163:56: error: passing argument 2 of ‘Tcl_Merge’ from incompatible pointer type [-Wincompatible-pointer-types]
 7163 |    Tcl_AppendElement(curFile->interp,Tcl_Merge(numRows,rowlist));
      |                                                        ^~~~~~~
      |                                                        |
      |                                                        char **
/usr/include/tcl/tclDecls.h:584:66: note: expected ‘const char * const*’ but argument is of type ‘char **’
  584 | EXTERN char *           Tcl_Merge(int argc, CONST84 char *const *argv);
make[1]: *** [Makefile:92: fitsCmds.o] Error 1
make[1]: *** [Makefile:92: fitsIO.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:8: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2