[Debian-astro-maintainers] Bug#1075648: x11iraf: ftbfs with GCC-14

[Matthias Klose]

Package: src:x11iraf
Version: 2.1+dfsg-3
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/x11iraf_2.1+dfsg-3_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
 4771 |                 sprintf (op, "%u %d %d %d %d ",
      |                               ~^
      |                                |
      |                                unsigned int
      |                               %lu
 4772 |                     ev->time, ev->x, ev->y, ev->x_root, ev->y_root);
      |                     ~~~~~~~~    
      |                       |
      |                       Time {aka long unsigned int}
widget.c:4802:32: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Time’ {aka ‘long unsigned int’} [-Wformat=]
 4802 |                 sprintf (op, "%u %d %d %d %d ",
      |                               ~^
      |                                |
      |                                unsigned int
      |                               %lu
 4803 |                     ev->time, ev->x, ev->y, ev->x_root, ev->y_root);
      |                     ~~~~~~~~    
      |                       |
      |                       Time {aka long unsigned int}
widget.c:4826:29: warning: ‘XKeycodeToKeysym’ is deprecated [-Wdeprecated-declarations]
 4826 |                             keysym = XKeycodeToKeysym (obm->display,
      |                             ^~~~~~
In file included from /usr/include/X11/Intrinsic.h:53,
                 from ObmP.h:16:
/usr/include/X11/Xlib.h:1687:15: note: declared here
 1687 | extern KeySym XKeycodeToKeysym(
      |               ^~~~~~~~~~~~~~~~
widget.c:4844:32: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Time’ {aka ‘long unsigned int’} [-Wformat=]
 4844 |                 sprintf (op, "%u %d %d %d %d ",
      |                               ~^
      |                                |
      |                                unsigned int
      |                               %lu
 4845 |                     ev->time, ev->x, ev->y, ev->x_root, ev->y_root);
      |                     ~~~~~~~~    
      |                       |
      |                       Time {aka long unsigned int}
widget.c: In function ‘widgetGetFontName’:
widget.c:5015:43: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
 5015 |                         sprintf(name, "%s%d", name, val);
      |                                          ~^         ~~~
      |                                           |         |
      |                                           int       long unsigned int
      |                                          %ld
make[2]: *** [<builtin>: widget.o] Error 1
Obm.c: In function ‘ObmActivate’:
Obm.c:311:64: warning: ‘%s’ directive writing 29 bytes into a region of size between 13 and 394 [-Wformat-overflow=]
  311 |             sprintf (defaultUI, "%s %s %s {%s.objects: %s%s%s%s%s}; %s; %s\n",
      |                                                                ^~
......
  317 |                 "*gterm.deiconifyWindow: True\n",
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                
In file included from /usr/include/stdio.h:964,
                 from ObmP.h:8,
                 from Obm.c:5:
In function ‘sprintf’,
    inlined from ‘ObmActivate’ at Obm.c:311:6:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 187 and 568 bytes into a destination of size 512
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obm'
make[1]: *** [Makefile:11: obm/libobm.a] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2