[Debian-astro-maintainers] Bug#1076251: cpl-plugin-xshoo: FTBFS with gsl/2.8: xsh_subtract_sky_single.c:2101:21: error: ‘gsl_bspline_workspace’ has no member named ‘l’

[Yavor Doganov]

Source: cpl-plugin-xshoo
Version: 3.5.3+dfsg-1
Severity: important
Tags: sid trixie ftbfs
User: edd at debian.org
Usertags: gsl_2.8-transition

This package fails to build with gsl/2.8 from experimental; relevant
part of the build log:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -DCX_LOG_DOMAIN=\"XshLib\" -I../xsh -I../irplib -I../hdrl -I/usr/include/cpl -I/usr/include -I/usr/include/cfitsio -DIRPLIB_USE_FITS_UPDATE_CHECKSUM -Wdate-time -D_FORTIFY_SOURCE=2 -Werror=implicit-function-declaration -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fno-builtin -std=c99 -Wall -c xsh_subtract_sky_single.c  -fPIC -DPIC -o .libs/xsh_subtract_sky_single.o
xsh_subtract_sky_single.c: In function ‘xsh_create_sampl_table’:
xsh_subtract_sky_single.c:1315:16: warning: unused variable ‘wdiff’ [-Wunused-variable]
 1315 |         double wdiff=0;
      |                ^~~~~
xsh_subtract_sky_single.c: In function ‘xsh_bspline_knots_not_uniform’:
xsh_subtract_sky_single.c:2101:21: error: ‘gsl_bspline_workspace’ has no member named ‘l’
 2101 |   double a = value[w->l];
      |                     ^~
In file included from ./irplib_error.h:36,
                 from ./xsh_error.h:43,
                 from ./xsh_drl.h:35,
                 from xsh_subtract_sky_single.c:56:
xsh_subtract_sky_single.c:2103:37: error: ‘gsl_bspline_workspace’ has no member named ‘l’
 2103 |   xsh_msg("workspace size=%d",(int)w->l);
      |                                     ^~
./xsh_msg.h:121:39: note: in definition of macro ‘xsh_msg’
  121 | #define xsh_msg(...) cpl_msg_info("", __VA_ARGS__)
      |                                       ^~~~~~~~~~~
xsh_subtract_sky_single.c:2108:20: error: ‘gsl_bspline_workspace’ has no member named ‘k’
 2108 |   for (i = 0; i < w->k; i++)
      |                    ^~
xsh_subtract_sky_single.c:2111:18: error: ‘gsl_bspline_workspace’ has no member named ‘l’
 2111 |   for (i = 0, k=w->l-1 ; i < w->l - 1; i++,k--)
      |                  ^~
xsh_subtract_sky_single.c:2111:31: error: ‘gsl_bspline_workspace’ has no member named ‘l’
 2111 |   for (i = 0, k=w->l-1 ; i < w->l - 1; i++,k--)
      |                               ^~
xsh_subtract_sky_single.c:2113:34: error: ‘gsl_bspline_workspace’ has no member named ‘k’
 2113 |       gsl_vector_set (w->knots, w->k + i, value[k]);
      |                                  ^~
xsh_subtract_sky_single.c:2117:13: error: ‘gsl_bspline_workspace’ has no member named ‘n’
 2117 |   for (i = w->n; i < w->n + w->k; i++)
      |             ^~
xsh_subtract_sky_single.c:2117:23: error: ‘gsl_bspline_workspace’ has no member named ‘n’
 2117 |   for (i = w->n; i < w->n + w->k; i++)
      |                       ^~
xsh_subtract_sky_single.c:2117:30: error: ‘gsl_bspline_workspace’ has no member named ‘k’
 2117 |   for (i = w->n; i < w->n + w->k; i++)
      |                              ^~
...
make[4]: Leaving directory '/<<PKGBUILDDIR>>/xsh'
make[3]: *** [Makefile:989: all-recursive] Error 1

The full build log is available upon request.

The severity of this bug will be raised to "serious" as soon as
gsl/2.8 is uploaded to unstable.  (This package is not in testing so
this bug is not a blocker for the GSL transition.)