[Debian-astro-maintainers] Bug#1089268: montage: FTBFS with make 4.4.1

Santiago Vila sanvila at debian.org
Sat Dec 7 18:08:40 GMT 2024


Package: src:montage
Version: 6.0+dfsg-10
User: debian-qa at lists.debian.org
Usertags: make-4.4
Severity: important
Tags: ftbfs

Dear Maintainer,

This package fails to build from source with Make 4.4.1, most likely because of
changes in $(shell) environment handling: environment variables exported from
Makefiles are now made available to commands invoked using $(shell), which
can cause issues with recursive definitions in particular. See
https://salsa.debian.org/debian/make/-/blob/master/debian/NEWS for a complete
list of backward-incompatible changes since Make 4.3.

Below you will find how the builds end, hopefully the most relevant
part from the build log. A full build log is available here:

https://people.debian.org/~sanvila/make-4.4/build-logs/

Make 4.4.1 is currently available in experimental and will hopefully
soon be uploaded to unstable, at which time this bug will become
release-critical.

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Please reach out to the Make maintainer, Stephen Kitt <skitt at debian.org> if
you need help fixing this.

--------------------------------------------------------------------------------
montageViewer.c:7084:4: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  7084 |    fgets(line, 1024, fhist);
       |    ^~~~~~~~~~~~~~~~~~~~~~~~
montageViewer.c:7088:7: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  7088 |       fgets(line, 1024, fhist);
       |       ^~~~~~~~~~~~~~~~~~~~~~~~
montageViewer.c:7092:4: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  7092 |    fgets(line, 1024, fhist);
       |    ^~~~~~~~~~~~~~~~~~~~~~~~
montageViewer.c:7093:4: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  7093 |    fgets(line, 1024, fhist);
       |    ^~~~~~~~~~~~~~~~~~~~~~~~
montageViewer.c:7097:7: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  7097 |       fgets(line, 1024, fhist);
       |       ^~~~~~~~~~~~~~~~~~~~~~~~
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC -DFONT_DIR='"/<<PKGBUILDDIR>>/data/fonts/"' -I. -I.. -I../../lib/include -I../../lib/freetype/include -I../../lib/freetype/include/freetype2 -I../../Montage -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/wcstools -I/usr/include/freetype2  -c  mViewer_graphics.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC -DFONT_DIR='"/<<PKGBUILDDIR>>/data/fonts/"' -I. -I.. -I../../lib/include -I../../lib/freetype/include -I../../lib/freetype/include/freetype2 -I../../Montage -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/wcstools -I/usr/include/freetype2  -c  mViewer_grid.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC -DFONT_DIR='"/<<PKGBUILDDIR>>/data/fonts/"' -I. -I.. -I../../lib/include -I../../lib/freetype/include -I../../lib/freetype/include/freetype2 -I../../Montage -o mViewer mViewer.o montageViewer.o mViewer_graphics.o mViewer_grid.o \
	../util/checkHdr.o   \
	../util/checkWCS.o   \
	-L../../lib -lwcstools -lcoord -lcfitsio -ljpeg -llodepng -lmtbl -ljson -lcmd -L../../lib/freetype/lib -lfreetype -lm
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/Viewer'
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/Viewer'
cp mViewer ../../bin
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/Viewer'
(cd DiffExec &&                      make && make install)
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/DiffExec'
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  mDiffExec.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  montageDiffExec.c
gcc -o mDiffExec mDiffExec.o montageDiffExec.o ../Diff/montageDiff.o \
                          ../util/checkHdr.o ../util/checkWCS.o ../util/filePath.o -Wl,-z,relro -L../../lib -lwcstools -lmtbl -lcfitsio -lm
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/DiffExec'
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/DiffExec'
cp mDiffExec ../../bin
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/DiffExec'
(cd BgExec &&                        make && make install)
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/BgExec'
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  mBgExec.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  montageBgExec.c
gcc -o mBgExec mBgExec.o montageBgExec.o ../Background/montageBackground.o \
                        ../util/checkHdr.o ../util/checkWCS.o ../util/filePath.o -Wl,-z,relro -L../../lib -lwcstools -lmtbl -lcfitsio -lm
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/BgExec'
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/BgExec'
cp mBgExec ../../bin
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/BgExec'
(cd DiffFitExec &&                   make && make install)
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/DiffFitExec'
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  mDiffFitExec.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  montageDiffFitExec.c
montageDiffFitExec.c: In function ‘mDiffFitExec’:
montageDiffFitExec.c:121:7: warning: argument 1 null where non-null expected [-Wnonnull]
   121 |       fclose(fout);
       |       ^~~~~~~~~~~~
In file included from montageDiffFitExec.c:11:
/usr/include/stdio.h:184:12: note: in a call to function ‘fclose’ declared ‘nonnull’
   184 | extern int fclose (FILE *__stream) __nonnull ((1));
       |            ^~~~~~
gcc -o mDiffFitExec mDiffFitExec.o montageDiffFitExec.o \
                             ../Diff/montageDiff.o ../Fitplane/montageFitplane.o \
                             ../util/checkHdr.o ../util/checkWCS.o ../util/filePath.o -Wl,-z,relro -L../../lib -lwcstools -lmtbl -lpixbounds -lcfitsio -lm
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/DiffFitExec'
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/DiffFitExec'
cp mDiffFitExec ../../bin
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/DiffFitExec'
(cd FitExec &&                       make && make install)
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/FitExec'
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  mFitExec.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  montageFitExec.c
gcc -o mFitExec mFitExec.o montageFitExec.o ../Fitplane/montageFitplane.o \
                         ../util/checkHdr.o ../util/checkWCS.o ../util/filePath.o ../util/checkFile.o -Wl,-z,relro -L../../lib -lwcstools -lmtbl -lpixbounds -lcfitsio -lm
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/FitExec'
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/FitExec'
cp mFitExec ../../bin
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/FitExec'
(cd ProjExec &&                      make && make install)
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/ProjExec'
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  mProjExec.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -I/usr/include/wcstools -I. -I.. -I../../lib/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC  -c  montageProjExec.c
gcc -o mProjExec mProjExec.o montageProjExec.o \
	../TANHdr/montageTANHdr.o \
	../GetHdr/montageGetHdr.o \
	../ProjectCube/montageProjectCube.o \
	../Project/montageProject.o \
	../ProjectQL/montageProjectQL.o \
	../ProjectPP/montageProjectPP.o \
	../util/checkFile.o ../util/filePath.o ../util/debugCheck.o ../util/checkHdr.o \
	../util/checkWCS.o -Wl,-z,relro -L../../lib -lwcstools -lmtbl -lwww -lcoord -ltwoplane -lcfitsio -lm
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/ProjExec'
make[4]: Entering directory '/<<PKGBUILDDIR>>/MontageLib/ProjExec'
cp mProjExec ../../bin
make[4]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib/ProjExec'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/MontageLib'
make[2]: *** [Makefile:11: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j2 "INSTALL=install --strip-program=true" returned exit code 2
make[1]: *** [debian/rules:24: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:14: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------------



More information about the Debian-astro-maintainers mailing list