[Debian-astro-maintainers] Bug#1096426: cfitsio: ftbfs with GCC-15

Mon Feb 17 17:06:49 GMT 2025

Package: src:cfitsio
Version: 4.5.0-5
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/cfitsio_4.5.0-5_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |                                                       ^~~~~~~
modkey.c:713:47: warning: unused variable 'contin' [-Wunused-variable]
  713 |     int next, remain, nquote, nchar, namelen, contin, tstatus = -1;
      |                                               ^~~~~~
modkey.c:713:38: warning: unused variable 'namelen' [-Wunused-variable]
  713 |     int next, remain, nquote, nchar, namelen, contin, tstatus = -1;
      |                                      ^~~~~~~
modkey.c:713:31: warning: unused variable 'nchar' [-Wunused-variable]
  713 |     int next, remain, nquote, nchar, namelen, contin, tstatus = -1;
      |                               ^~~~~
modkey.c:713:23: warning: unused variable 'nquote' [-Wunused-variable]
  713 |     int next, remain, nquote, nchar, namelen, contin, tstatus = -1;
      |                       ^~~~~~
modkey.c:713:15: warning: unused variable 'remain' [-Wunused-variable]
  713 |     int next, remain, nquote, nchar, namelen, contin, tstatus = -1;
      |               ^~~~~~
modkey.c:713:9: warning: unused variable 'next' [-Wunused-variable]
  713 |     int next, remain, nquote, nchar, namelen, contin, tstatus = -1;
      |         ^~~~
modkey.c:711:32: warning: unused variable 'cptr' [-Wunused-variable]
  711 |     char tstring[FLEN_VALUE], *cptr;
      |                                ^~~~
modkey.c:711:10: warning: unused variable 'tstring' [-Wunused-variable]
  711 |     char tstring[FLEN_VALUE], *cptr;
      |          ^~~~~~~
modkey.c:710:27: warning: unused variable 'tmpkeyname' [-Wunused-variable]
  710 |     char card[FLEN_CARD], tmpkeyname[FLEN_CARD];
      |                           ^~~~~~~~~~
modkey.c:709:10: warning: unused variable 'valstring' [-Wunused-variable]
  709 |     char valstring[FLEN_VALUE];
      |          ^~~~~~~~~
libtool: compile:  x86_64-linux-gnu-gcc -DPACKAGE_NAME=\"cfitsio\" -DPACKAGE_TARNAME=\"cfitsio\" -DPACKAGE_VERSION=\"4.5.0\" "-DPACKAGE_STRING=\"cfitsio 4.5.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"cfitsio\" -DVERSION=\"4.5.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBBZ2=1 -DHAVE_BZLIB_H=1 -DHAVE_BZIP2=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MATH_H=1 -DHAVE_LIMITS_H=1 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DCFITSIO_HAVE_CURL=1 -DHAVE_LIBZ=1 -DHAVE_FTRUNCATE=1 -DHAVE_LONGLONG=1 -DHAVE_SHMEM_SERVICES=1 -D_REENTRANT=1 -D_XOPEN_SOURCE=700 -DHAVE_LIBPTHREAD=1 -DHAVE_FMEMOPEN=1 -DHAVE_NET_SERVICES=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -DPACKAGE_NAME=\"cfitsio\" -DPACKAGE_TARNAME=\"cfitsio\" -DPACKAGE_VERSION=\"4.5.0\" "-DPACKAGE_STRING=\"cfitsio 4.5.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"cfitsio\" -DVERSION=\"4.5.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBBZ2=1 -DHAVE_BZLIB_H=1 -DHAVE_BZIP2=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MATH_H=1 -DHAVE_LIMITS_H=1 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DCFITSIO_HAVE_CURL=1 -DHAVE_LIBZ=1 -DHAVE_FTRUNCATE=1 -DHAVE_LONGLONG=1 -DHAVE_SHMEM_SERVICES=1 -D_REENTRANT=1 -D_XOPEN_SOURCE=700 -DHAVE_LIBPTHREAD=1 -DHAVE_FMEMOPEN=1 -DHAVE_NET_SERVICES=1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/cfitsio-4.5.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Dg77Fortran -c histo.c -o libcfitsio_la-histo.o >/dev/null 2>&1
modkey.c: In function 'ffikls':
modkey.c:1270:12: warning: '__builtin_strncpy' output truncated copying 2 bytes from a string of length 3 [-Wstringop-truncation]
 1270 |            strncpy(&card[8], "   ",  2);  /* overwrite the '=' */
      |            ^
/bin/bash ./libtool  --tag=CC   --mode=compile x86_64-linux-gnu-gcc -DPACKAGE_NAME=\"cfitsio\" -DPACKAGE_TARNAME=\"cfitsio\" -DPACKAGE_VERSION=\"4.5.0\" -DPACKAGE_STRING=\"cfitsio\ 4.5.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"cfitsio\" -DVERSION=\"4.5.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBBZ2=1 -DHAVE_BZLIB_H=1 -DHAVE_BZIP2=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MATH_H=1 -DHAVE_LIMITS_H=1 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DCFITSIO_HAVE_CURL=1 -DHAVE_LIBZ=1 -DHAVE_FTRUNCATE=1 -DHAVE_LONGLONG=1 -DHAVE_SHMEM_SERVICES=1 -D_REENTRANT=1 -D_XOPEN_SOURCE=700 -DHAVE_LIBPTHREAD=1 -DHAVE_FMEMOPEN=1 -DHAVE_NET_SERVICES=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -DPACKAGE_NAME=\"cfitsio\" -DPACKAGE_TARNAME=\"cfitsio\" -DPACKAGE_VERSION=\"4.5.0\" -DPACKAGE_STRING=\"cfitsio\ 4.5.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"cfitsio\" -DVERSION=\"4.5.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBBZ2=1 -DHAVE_BZLIB_H=1 -DHAVE_BZIP2=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MATH_H=1 -DHAVE_LIMITS_H=1 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DCFITSIO_HAVE_CURL=1 -DHAVE_LIBZ=1 -DHAVE_FTRUNCATE=1 -DHAVE_LONGLONG=1 -DHAVE_SHMEM_SERVICES=1 -D_REENTRANT=1 -D_XOPEN_SOURCE=700 -DHAVE_LIBPTHREAD=1 -DHAVE_FMEMOPEN=1 -DHAVE_NET_SERVICES=1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/cfitsio-4.5.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Dg77Fortran -c -o libcfitsio_la-putcol.lo `test -f 'putcol.c' || echo './'`putcol.c
libtool: compile:  x86_64-linux-gnu-gcc -DPACKAGE_NAME=\"cfitsio\" -DPACKAGE_TARNAME=\"cfitsio\" -DPACKAGE_VERSION=\"4.5.0\" "-DPACKAGE_STRING=\"cfitsio 4.5.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"cfitsio\" -DVERSION=\"4.5.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBBZ2=1 -DHAVE_BZLIB_H=1 -DHAVE_BZIP2=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MATH_H=1 -DHAVE_LIMITS_H=1 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DCFITSIO_HAVE_CURL=1 -DHAVE_LIBZ=1 -DHAVE_FTRUNCATE=1 -DHAVE_LONGLONG=1 -DHAVE_SHMEM_SERVICES=1 -D_REENTRANT=1 -D_XOPEN_SOURCE=700 -DHAVE_LIBPTHREAD=1 -DHAVE_FMEMOPEN=1 -DHAVE_NET_SERVICES=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -DPACKAGE_NAME=\"cfitsio\" -DPACKAGE_TARNAME=\"cfitsio\" -DPACKAGE_VERSION=\"4.5.0\" "-DPACKAGE_STRING=\"cfitsio 4.5.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"cfitsio\" -DVERSION=\"4.5.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBBZ2=1 -DHAVE_BZLIB_H=1 -DHAVE_BZIP2=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MATH_H=1 -DHAVE_LIMITS_H=1 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DCFITSIO_HAVE_CURL=1 -DHAVE_LIBZ=1 -DHAVE_FTRUNCATE=1 -DHAVE_LONGLONG=1 -DHAVE_SHMEM_SERVICES=1 -D_REENTRANT=1 -D_XOPEN_SOURCE=700 -DHAVE_LIBPTHREAD=1 -DHAVE_FMEMOPEN=1 -DHAVE_NET_SERVICES=1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/cfitsio-4.5.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Dg77Fortran -c putcol.c  -fPIC -DPIC -o .libs/libcfitsio_la-putcol.o
modkey.c: In function 'ffpunt':
modkey.c:588:13: warning: '__builtin___strncat_chk' output may be truncated copying between 0 and 72 bytes from a string of length 72 [-Wstringop-truncation]
  588 |             strncat(newcomm, oldcomm, len);  /* append old comment onto new */
      |             ^
putcol.c: In function 'ffiter':
putcol.c:1229:24: error: expected identifier or '(' before 'nullptr'
 1229 |     char **stringptr, *nullptr, *cptr;
      |                        ^~~~~~~
putcol.c:1672:25: error: 'cptr' undeclared (first use in this function)
 1672 |                         cptr = nullstr;
      |                         ^~~~
putcol.c:1672:25: note: each undeclared identifier is reported only once for each function it appears in
putcol.c:2084:21: error: lvalue required as left operand of assignment
 2084 |             nullptr = *stringptr;
      |                     ^
putcol.c:2090:21: error: lvalue required as left operand of assignment
 2090 |             nullptr = (char *) cols[jj].array;
      |                     ^
putcol.c:2094:15: warning: argument 1 null where non-null expected [-Wnonnull]
 2094 |           if (memcmp(nullptr, &zeros, nbytes) )
      |               ^~~~~~
In file included from putcol.c:8:
/usr/include/string.h:64:12: note: in a call to function 'memcmp' declared 'nonnull'
   64 | extern int memcmp (const void *__s1, const void *__s2, size_t __n)
      |            ^~~~~~
make[1]: *** [Makefile:1221: libcfitsio_la-putcol.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
libtool: compile:  x86_64-linux-gnu-gcc -DPACKAGE_NAME=\"cfitsio\" -DPACKAGE_TARNAME=\"cfitsio\" -DPACKAGE_VERSION=\"4.5.0\" "-DPACKAGE_STRING=\"cfitsio 4.5.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"cfitsio\" -DVERSION=\"4.5.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBBZ2=1 -DHAVE_BZLIB_H=1 -DHAVE_BZIP2=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MATH_H=1 -DHAVE_LIMITS_H=1 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DCFITSIO_HAVE_CURL=1 -DHAVE_LIBZ=1 -DHAVE_FTRUNCATE=1 -DHAVE_LONGLONG=1 -DHAVE_SHMEM_SERVICES=1 -D_REENTRANT=1 -D_XOPEN_SOURCE=700 -DHAVE_LIBPTHREAD=1 -DHAVE_FMEMOPEN=1 -DHAVE_NET_SERVICES=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -DPACKAGE_NAME=\"cfitsio\" -DPACKAGE_TARNAME=\"cfitsio\" -DPACKAGE_VERSION=\"4.5.0\" "-DPACKAGE_STRING=\"cfitsio 4.5.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"cfitsio\" -DVERSION=\"4.5.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBBZ2=1 -DHAVE_BZLIB_H=1 -DHAVE_BZIP2=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MATH_H=1 -DHAVE_LIMITS_H=1 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DCFITSIO_HAVE_CURL=1 -DHAVE_LIBZ=1 -DHAVE_FTRUNCATE=1 -DHAVE_LONGLONG=1 -DHAVE_SHMEM_SERVICES=1 -D_REENTRANT=1 -D_XOPEN_SOURCE=700 -DHAVE_LIBPTHREAD=1 -DHAVE_FMEMOPEN=1 -DHAVE_NET_SERVICES=1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/cfitsio-4.5.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Dg77Fortran -c modkey.c -o libcfitsio_la-modkey.o >/dev/null 2>&1
make[1]: Leaving directory '/build/reproducible-path/cfitsio-4.5.0'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:9: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2