[Debian-astro-maintainers] Bug#1097844: saods9: ftbfs with GCC-15

[Matthias Klose]

Package: src:saods9
Version: 8.6+repack-4
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/saods9_8.6+repack-4_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
iis/iistcl.C: In constructor ‘IIS::IIS(Tcl_Interp*)’:
iis/iistcl.C:118:11: warning: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ output truncated before terminating nul copying 23 bytes from a string of the same length [-Wstringop-truncation]
  118 |   strncpy (xim.imtoolrc, FBCONFIG_2, strlen(FBCONFIG_2));
      |           ^
frame/wcsast.C: In function ‘AstWinMap* wcsWinMap(AstFrameSet*, Vector&, Vector&, Vector&)’:
frame/wcsast.C:588:47: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  588 |       return astWinMap(2, vll, vrr, vll, vur, "");
      |                                               ^~
frame/wcsast.C:591:61: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  591 |     return astWinMap(2, ll.vv(), rr.vv(), ll.vv(), ur.vv(), "");
      |                                                             ^~
frame/wcsast.C:606:47: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  606 |       return astWinMap(3, vll, vrr, vll, vur, "");
      |                                               ^~
frame/wcsast.C:625:47: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  625 |       return astWinMap(4, vll, vrr, vll, vur, "");
      |                                               ^~
frame/wcsast.C:647:47: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  647 |       return astWinMap(4, vll, vrr, vll, vur, "");
      |                                               ^~
frame/wcsast.C: In function ‘AstCmpMap* wcsMatrixMap(AstFrameSet*, Matrix&)’:
frame/wcsast.C:667:38: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  667 |       mm = astMatrixMap(2, 2, 0, ss, "");
      |                                      ^~
frame/wcsast.C:668:31: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  668 |       sm = astShiftMap(2, tt, "");
      |                               ^~
frame/wcsast.C:675:38: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  675 |       mm = astMatrixMap(2, 2, 0, ss, "");
      |                                      ^~
frame/wcsast.C:676:31: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  676 |       sm = astShiftMap(2, tt, "");
      |                               ^~
frame/wcsast.C:685:38: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  685 |       mm = astMatrixMap(3, 3, 0, ss, "");
      |                                      ^~
frame/wcsast.C:686:31: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  686 |       sm = astShiftMap(3, tt, "");
      |                               ^~
frame/wcsast.C:696:38: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  696 |       mm = astMatrixMap(4, 4, 0, ss, "");
      |                                      ^~
frame/wcsast.C:697:31: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  697 |       sm = astShiftMap(4, tt, "");
      |                               ^~
frame/wcsast.C:707:38: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  707 |       mm = astMatrixMap(5, 5, 0, ss, "");
      |                                      ^~
frame/wcsast.C:708:31: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  708 |       sm = astShiftMap(5, tt, "");
      |                               ^~
frame/wcsast.C:714:33: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  714 |     return astCmpMap(mm, sm, 1, "");
      |                                 ^~
frame/tngparser.Y: In function ‘int tngparse(Base*, tngFlexLexer*)’:
frame/tngparser.Y:338:13: warning: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ output may be truncated copying 80 bytes from a string of length 2047 [-Wstringop-truncation]
  338 |         | '#' {DISCARD_(1);} STRING {strncpy(localComment,$3,80);}
      |             ^
frame/tngparser.Y:316:20: warning: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ output may be truncated copying 80 bytes from a string of length 2047 [-Wstringop-truncation]
  316 |         | '#' {DISCARD_(1);} STRING {strncpy(globalText,$3,80);}
      |                    ^
frame/tngparser.Y:294:20: warning: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ output may be truncated copying 80 bytes from a string of length 2047 [-Wstringop-truncation]
  294 |         | TEXT_ bp coord sp STRING ep {strncpy(localText,$5,80);} shapeComment
      |                    ^
make[2]: Leaving directory '/build/reproducible-path/saods9-8.6+repack/tksao'
dh_auto_build: error: cd tksao && make -j8 returned exit code 2
make[1]: *** [debian/rules:22: override_dh_auto_build] Error 25
make[1]: Leaving directory '/build/reproducible-path/saods9-8.6+repack'
make: *** [debian/rules:9: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2