[Debian-astro-maintainers] Bug#1110977: trixie-pu: package pyraf/2.2.2-4+deb13u1

[Ole Streicher]

Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: pyraf at packages.debian.org
Control: affects -1 + src:pyraf
User: release.debian.org at packages.debian.org
Usertags: pu


Dear release team,

please approve the upload of 2.2.2-4+deb13u1 to Debian Trixie.

[ Reason ]

pyraf/2.2.4-3 delivered with Trixie comes with a bug that was
undiscovered but makes the package unusable for almost all use cases.

[ Impact ]

PyRAF is one of the central user-sided packages for work with IRAF. A
non-working PyRAF would signifcantly decrease the usability of the
IRAF ecosystem in Debian.

[ Tests ]

The package passes its automated tests, and was tested manually
against the use case described in the bug report.

The patch is a backport of a significant part of an upstream commit,
which is in tests since a few months.
[ Risks ]

The package has no reverse dependencies, and the patch itself is
trivial. Therefore the risk to break something is very low.

[ Checklist ]
   [X] *all* changes are documented in the d/changelog
   [X] I reviewed all changes and I approve them
   [X] attach debdiff against the package in (old)stable
   [X] the issue is verified as fixed in unstable

[ Changes ]

The patch comments out one source code line that sets an unused
attribute in a Python object initialization with the result of a
function. This function is not compatible to Python 3.13. In the
upstream commit, both the function definition and the function call is
removed, but to keep the patch minimal, here we only remove the
function call.

[ Other info ]

None

Thank you very much

Ole
-------------- next part --------------
diff -Nru pyraf-2.2.2/debian/changelog pyraf-2.2.2/debian/changelog
--- pyraf-2.2.2/debian/changelog	2025-05-02 21:13:22.000000000 +0200
+++ pyraf-2.2.2/debian/changelog	2025-08-13 09:48:47.000000000 +0200
@@ -1,3 +1,15 @@
+pyraf (2.2.2-4+deb13u1) trixie; urgency=medium
+
+  * Upload to stable
+
+ -- Ole Streicher <olebole at debian.org>  Wed, 13 Aug 2025 09:48:47 +0200
+
+pyraf (2.2.2-4) unstable; urgency=medium
+
+  * Fix graphical init for work with Python 3.13. Closes: #1110708
+
+ -- Ole Streicher <olebole at debian.org>  Tue, 12 Aug 2025 19:59:59 +0200
+
 pyraf (2.2.2-3) unstable; urgency=medium
 
   * Mark test that failed on i386 as xfail (Closes: #1103060)
diff -Nru pyraf-2.2.2/debian/patches/Fix-graphical-init-for-work-with-Python-3.13.patch pyraf-2.2.2/debian/patches/Fix-graphical-init-for-work-with-Python-3.13.patch
--- pyraf-2.2.2/debian/patches/Fix-graphical-init-for-work-with-Python-3.13.patch	1970-01-01 01:00:00.000000000 +0100
+++ pyraf-2.2.2/debian/patches/Fix-graphical-init-for-work-with-Python-3.13.patch	2025-08-10 13:08:16.000000000 +0200
@@ -0,0 +1,38 @@
+From: Ole Streicher <olebole at debian.org>
+Date: Sun, 10 Aug 2025 11:58:06 +0200
+Subject: Fix graphical init for work with Python 3.13
+
+As pointed out in https://github.com/iraf-community/pyraf/issues/182,
+version 2.2.2-3 fails to work properly with Python 3.13:
+
+    $ pyraf -c 'onedspec; splot dev$pix 34'
+    [...]
+      File "/usr/lib/python3/dist-packages/pyraf/gki.py", line 1423, in
+__init__
+        p[0:4] = [0x92, 0x49, 0x24, 0x92]
+    OverflowError: Python integer 146 out of bounds for int8
+
+    PANIC in `/usr/lib/iraf/noao/bin/x_onedspec.e': Write to IPC with
+no reader
+
+The proper solution is to apply
+https://github.com/iraf-community/pyraf/pull/176; however for a minimal
+fix one can just remove the line 208 from   pyraf/pyraf/gkitkbase.py.
+
+Closes: #1110708
+---
+ pyraf/gkitkbase.py | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/pyraf/gkitkbase.py b/pyraf/gkitkbase.py
+index e55fe18..e77373d 100644
+--- a/pyraf/gkitkbase.py
++++ b/pyraf/gkitkbase.py
+@@ -205,7 +205,6 @@ class GkiInteractiveTkBase(gki.GkiKernel, wutil.FocusEntity):
+         self.colorManager.setColors(self.gwidget)
+         self.wcs = irafgwcs.IrafGWcs()
+         self.linestyles = gki.IrafLineStyles()
+-        self.hatchfills = gki.IrafHatchFills()
+         self.textAttributes = gki.TextAttributes()
+         self.lineAttributes = gki.LineAttributes()
+         self.fillAttributes = gki.FillAttributes()
diff -Nru pyraf-2.2.2/debian/patches/series pyraf-2.2.2/debian/patches/series
--- pyraf-2.2.2/debian/patches/series	2025-05-02 21:13:22.000000000 +0200
+++ pyraf-2.2.2/debian/patches/series	2025-08-10 13:08:16.000000000 +0200
@@ -1,3 +1,4 @@
 Use-system-provided-iraf-by-default.patch
 Update-test_compmixin.py-for-Python-3.13.patch
 Mark-test-that-failed-on-i386-as-xfail.patch
+Fix-graphical-init-for-work-with-Python-3.13.patch