[Debian-astro-maintainers] Bug#1115249: aoflagger: FTBFS with glibc 2.42 due to conflict with the newly added pown function

[Aurelien Jarno]

Source: aoflagger
Version: 3.4.0-3
Severity: important
Tags: ftbfs forky sid
Justification: fails to build from source
User: debian-glibc at lists.debian.org
Usertags: glibc-2.42

Dear maintainer,

During a rebuild of all packages in unstable with glibc 2.42 from
experimental, your package failed to build. Below you will find how the
build ends. If required, the full build log is available here:

https://people.debian.org/~aurel32/glibc-2.42/

The build failure is due to the addition of the pown function (part of
ISO C23) to glibc 2.42, now conflicting with the aoflagger source:

https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=f0b0e924a45c7698e6ca6415f2d9a096a24e37df;hb=d2097651cc57834dbfcaa102ddfacae0d86cfb66#l12

About the archive rebuild: The build was made on virtual machines from
AWS, using sbuild, a reduced chroot with only build-essential packages
and glibc 2.42 from experimental.

Regards
Aurelien

--------------------------------------------------------------------------------
[...]
/usr/bin/c++ -DBOOST_DATE_TIME_DYN_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DHAVE_GTKMM -DHAVE_POSIX_FALLOCATE -Daoflagger_lib_EXPORTS -I/<<PKGBUILDDIR>>/external/aocommon/include -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -isystem /usr/include/python3.13 -isystem /usr/include/hdf5/serial -isystem /usr/include/casacore -isystem /usr/include/lua5.3 -isystem /usr/include/gtkmm-3.0 -isystem /usr/lib/x86_64-linux-gnu/gtkmm-3.0/include -isystem /usr/include/giomm-2.4 -isystem /usr/lib/x86_64-linux-gnu/giomm-2.4/include -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/sysprof-6 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glibmm-2.4 -isystem /usr/lib/x86_64-linux-gnu/glibmm-2.4/include -isystem /usr/include/sigc++-2.0 -isystem /usr/lib/x86_64-linux-gnu/sigc++-2.0/include -isystem /usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -isystem /usr/include/harfbuzz -isystem /usr/include/freetype2 -isystem /usr/include/libpng16 -isystem /usr/include/fribidi -isystem /usr/include/cairo -isystem /usr/include/pixman-1 -isystem /usr/include/gdk-pixbuf-2.0 -isystem /usr/include/webp -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/cloudproviders -isystem /usr/include/atk-1.0 -isystem /usr/include/at-spi2-atk/2.0 -isystem /usr/include/at-spi-2.0 -isystem /usr/include/dbus-1.0 -isystem /usr/lib/x86_64-linux-gnu/dbus-1.0/include -isystem /usr/include/cairomm-1.0 -isystem /usr/lib/x86_64-linux-gnu/cairomm-1.0/include -isystem /usr/include/pangomm-1.4 -isystem /usr/lib/x86_64-linux-gnu/pangomm-1.4/include -isystem /usr/include/atkmm-1.6 -isystem /usr/lib/x86_64-linux-gnu/atkmm-1.6/include -isystem /usr/include/gtk-3.0/unix-print -isystem /usr/include/gdkmm-3.0 -isystem /usr/lib/x86_64-linux-gnu/gdkmm-3.0/include -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -fPIC -DNDEBUG -O3 -Wall -Wvla -Wzero-as-null-pointer-constant -Wnon-virtual-dtor -Wduplicated-branches -Wundef -Wpointer-arith -Wextra -Wno-unused-parameter -MD -MT CMakeFiles/aoflagger-lib.dir/algorithms/antennaselector.cpp.o -MF CMakeFiles/aoflagger-lib.dir/algorithms/antennaselector.cpp.o.d -o CMakeFiles/aoflagger-lib.dir/algorithms/antennaselector.cpp.o -c /<<PKGBUILDDIR>>/algorithms/antennaselector.cpp
In file included from /<<PKGBUILDDIR>>/algorithms/../quality/../structures/image2d.h:8,
                 from /<<PKGBUILDDIR>>/algorithms/../quality/statisticscollection.h:6,
                 from /<<PKGBUILDDIR>>/algorithms/antennaselector.cpp:5:
/<<PKGBUILDDIR>>/algorithms/../quality/../structures/types.h:30:20: warning: declaration of ‘double powf(double, long long int)’ conflicts with built-in declaration ‘float powf(float, float)’ [-Wbuiltin-declaration-mismatch]
   30 | #define pown(X, Y) powf(X, Y)
      |                    ^~~~
In file included from /usr/include/c++/15/cmath:55,
                 from /<<PKGBUILDDIR>>/algorithms/../quality/../structures/image2d.h:13:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:177:1: error: conflicting declaration of C function ‘float powf(float, float)’
  177 | __MATHCALL_VEC (pow,, (_Mdouble_ __x, _Mdouble_ __y));
      | ^~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/algorithms/../quality/../structures/types.h:30:20: note: previous declaration ‘double powf(double, long long int)’
   30 | #define pown(X, Y) powf(X, Y)
      |                    ^~~~
/<<PKGBUILDDIR>>/algorithms/../quality/../structures/types.h:74:21: error: conflicting declaration of C function ‘long double powl(long double, long long int)’
   74 | #define pownl(X, Y) powl(X, Y)
      |                     ^~~~
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:177:1: note: previous declaration ‘long double powl(long double, long double)’
  177 | __MATHCALL_VEC (pow,, (_Mdouble_ __x, _Mdouble_ __y));
      | ^~~~~~~~~~~~~~
make[3]: *** [CMakeFiles/aoflagger-lib.dir/build.make:82: CMakeFiles/aoflagger-lib.dir/algorithms/antennaselector.cpp.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:1081: CMakeFiles/aoflagger-lib.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[  2%] Building CXX object CMakeFiles/aoflaggergui.dir/rfigui/controllers/rfiguicontroller.cpp.o
/usr/bin/c++ -DHAVE_GTKMM -DHAVE_POSIX_FALLOCATE -I/<<PKGBUILDDIR>>/external/aocommon/include -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -isystem /usr/include/python3.13 -isystem /usr/include/hdf5/serial -isystem /usr/include/casacore -isystem /usr/include/lua5.3 -isystem /usr/include/gtkmm-3.0 -isystem /usr/lib/x86_64-linux-gnu/gtkmm-3.0/include -isystem /usr/include/giomm-2.4 -isystem /usr/lib/x86_64-linux-gnu/giomm-2.4/include -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/sysprof-6 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glibmm-2.4 -isystem /usr/lib/x86_64-linux-gnu/glibmm-2.4/include -isystem /usr/include/sigc++-2.0 -isystem /usr/lib/x86_64-linux-gnu/sigc++-2.0/include -isystem /usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -isystem /usr/include/harfbuzz -isystem /usr/include/freetype2 -isystem /usr/include/libpng16 -isystem /usr/include/fribidi -isystem /usr/include/cairo -isystem /usr/include/pixman-1 -isystem /usr/include/gdk-pixbuf-2.0 -isystem /usr/include/webp -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/cloudproviders -isystem /usr/include/atk-1.0 -isystem /usr/include/at-spi2-atk/2.0 -isystem /usr/include/at-spi-2.0 -isystem /usr/include/dbus-1.0 -isystem /usr/lib/x86_64-linux-gnu/dbus-1.0/include -isystem /usr/include/cairomm-1.0 -isystem /usr/lib/x86_64-linux-gnu/cairomm-1.0/include -isystem /usr/include/pangomm-1.4 -isystem /usr/lib/x86_64-linux-gnu/pangomm-1.4/include -isystem /usr/include/atkmm-1.6 -isystem /usr/lib/x86_64-linux-gnu/atkmm-1.6/include -isystem /usr/include/gtk-3.0/unix-print -isystem /usr/include/gdkmm-3.0 -isystem /usr/lib/x86_64-linux-gnu/gdkmm-3.0/include -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -DNDEBUG -O3 -Wall -Wvla -Wzero-as-null-pointer-constant -Wnon-virtual-dtor -Wduplicated-branches -Wundef -Wpointer-arith -Wextra -Wno-unused-parameter -MD -MT CMakeFiles/aoflaggergui.dir/rfigui/controllers/rfiguicontroller.cpp.o -MF CMakeFiles/aoflaggergui.dir/rfigui/controllers/rfiguicontroller.cpp.o.d -o CMakeFiles/aoflaggergui.dir/rfigui/controllers/rfiguicontroller.cpp.o -c /<<PKGBUILDDIR>>/rfigui/controllers/rfiguicontroller.cpp
In file included from /<<PKGBUILDDIR>>/rfigui/controllers/../../structures/image2d.h:8,
                 from /<<PKGBUILDDIR>>/rfigui/controllers/../../structures/timefrequencydata.h:11,
                 from /<<PKGBUILDDIR>>/rfigui/controllers/rfiguicontroller.h:6,
                 from /<<PKGBUILDDIR>>/rfigui/controllers/rfiguicontroller.cpp:1:
/<<PKGBUILDDIR>>/rfigui/controllers/../../structures/types.h:30:20: warning: declaration of ‘double powf(double, long long int)’ conflicts with built-in declaration ‘float powf(float, float)’ [-Wbuiltin-declaration-mismatch]
   30 | #define pown(X, Y) powf(X, Y)
      |                    ^~~~
In file included from /usr/include/c++/15/cmath:55,
                 from /<<PKGBUILDDIR>>/rfigui/controllers/../../structures/image2d.h:13:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:177:1: error: conflicting declaration of C function ‘float powf(float, float)’
  177 | __MATHCALL_VEC (pow,, (_Mdouble_ __x, _Mdouble_ __y));
      | ^~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/rfigui/controllers/../../structures/types.h:30:20: note: previous declaration ‘double powf(double, long long int)’
   30 | #define pown(X, Y) powf(X, Y)
      |                    ^~~~
/<<PKGBUILDDIR>>/rfigui/controllers/../../structures/types.h:74:21: error: conflicting declaration of C function ‘long double powl(long double, long long int)’
   74 | #define pownl(X, Y) powl(X, Y)
      |                     ^~~~
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:177:1: note: previous declaration ‘long double powl(long double, long double)’
  177 | __MATHCALL_VEC (pow,, (_Mdouble_ __x, _Mdouble_ __y));
      | ^~~~~~~~~~~~~~
[  3%] Building CXX object CMakeFiles/aoflaggergui.dir/rfigui/gotowindow.cpp.o
/usr/bin/c++ -DHAVE_GTKMM -DHAVE_POSIX_FALLOCATE -I/<<PKGBUILDDIR>>/external/aocommon/include -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -isystem /usr/include/python3.13 -isystem /usr/include/hdf5/serial -isystem /usr/include/casacore -isystem /usr/include/lua5.3 -isystem /usr/include/gtkmm-3.0 -isystem /usr/lib/x86_64-linux-gnu/gtkmm-3.0/include -isystem /usr/include/giomm-2.4 -isystem /usr/lib/x86_64-linux-gnu/giomm-2.4/include -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/sysprof-6 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glibmm-2.4 -isystem /usr/lib/x86_64-linux-gnu/glibmm-2.4/include -isystem /usr/include/sigc++-2.0 -isystem /usr/lib/x86_64-linux-gnu/sigc++-2.0/include -isystem /usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -isystem /usr/include/harfbuzz -isystem /usr/include/freetype2 -isystem /usr/include/libpng16 -isystem /usr/include/fribidi -isystem /usr/include/cairo -isystem /usr/include/pixman-1 -isystem /usr/include/gdk-pixbuf-2.0 -isystem /usr/include/webp -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/cloudproviders -isystem /usr/include/atk-1.0 -isystem /usr/include/at-spi2-atk/2.0 -isystem /usr/include/at-spi-2.0 -isystem /usr/include/dbus-1.0 -isystem /usr/lib/x86_64-linux-gnu/dbus-1.0/include -isystem /usr/include/cairomm-1.0 -isystem /usr/lib/x86_64-linux-gnu/cairomm-1.0/include -isystem /usr/include/pangomm-1.4 -isystem /usr/lib/x86_64-linux-gnu/pangomm-1.4/include -isystem /usr/include/atkmm-1.6 -isystem /usr/lib/x86_64-linux-gnu/atkmm-1.6/include -isystem /usr/include/gtk-3.0/unix-print -isystem /usr/include/gdkmm-3.0 -isystem /usr/lib/x86_64-linux-gnu/gdkmm-3.0/include -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -DNDEBUG -O3 -Wall -Wvla -Wzero-as-null-pointer-constant -Wnon-virtual-dtor -Wduplicated-branches -Wundef -Wpointer-arith -Wextra -Wno-unused-parameter -MD -MT CMakeFiles/aoflaggergui.dir/rfigui/gotowindow.cpp.o -MF CMakeFiles/aoflaggergui.dir/rfigui/gotowindow.cpp.o.d -o CMakeFiles/aoflaggergui.dir/rfigui/gotowindow.cpp.o -c /<<PKGBUILDDIR>>/rfigui/gotowindow.cpp
make[3]: *** [CMakeFiles/aoflaggergui.dir/build.make:96: CMakeFiles/aoflaggergui.dir/rfigui/controllers/rfiguicontroller.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:1145: CMakeFiles/aoflaggergui.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:169: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j2 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:15: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------