Bug#850956: gosa-plugin-netgroups: fails to show the content of netgroup list entry (e.g. workstation-hosts)

[Wolfgang Schweer]

On Wed, Jan 11, 2017 at 08:53:57PM +0000, Mike Gabriel wrote:
> On  Mi 11 Jan 2017 16:47:51 CET, Wolfgang Schweer wrote:

[..]

> > while testing Debian Edu stretch another PHP7 issue (constructor name)
> > showed up.
> > 
> > Please note that for some reason replacing the function name with
> > '__constructor' doesn't work in this case.
> > 
> > This patch seems to fix it:
> > 
> > --- a/tabs_netgroup.inc	2017-01-11 16:20:32.203632303 +0100
> > +++ b/tabs_netgroup.inc	2017-01-11 16:13:58.399201779 +0100
> > @@ -23,7 +23,7 @@
> > 
> >  class netgrouptabs extends tabs {
> > 
> > -    function netgrouptabs($config, $data, $dn, $cat = "", $hide_refs =
> > FALSE, $hide_acls = FALSE) {
> > +    function __netgrouptabs($config, $data, $dn, $cat = "", $hide_refs
> > = FALSE, $hide_acls = FALSE) {
> >          tabs::__plugin($config, $data, $dn, "netgroups", $hide_refs,
> > $hide_acls);
> >          $this->addSpecialTabs();
> >      }

[..]

> Sorry, I doubt this, but are you sure about this?

While the above mentioned '__constructor' has been a typo this exact 
replacement actually works; but, '__construct' (like used elswhere in 
gosa to fix this PHP7 issue) does not. So yes, I'm pretty much sure.
 
> Can you second it with some official PHP7 porting document or such?

No, but I guess that '__construct' fails as class netgrouptabs extends 
tabs which already uses '__construct' - so anything different has to be 
used.

Wolfgang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-edu-pkg-team/attachments/20170111/3a22b946/attachment.sig>