Bug#1142729: openboard: will FTBFS with poppler 26.07

[Nadzeya Hutsko]

Source: openboard
Version: 1.7.7+dfsg-1
Severity: normal
Tags: ftbfs patch

Dear Maintainer,

openboard will FTBFS against poppler 26.07 (currently in experimental)
once it reaches unstable:

```
src/pdf/XPDFRenderer.cpp:182:49: error: base operand of '->' has
non-pointer type 'const std::string'
  182 |     return QString(title.getString()->c_str());
```

poppler 26.04 changed Object::getString() to return a const std::string&
instead of a GooString*, so title.getString()->c_str() no longer
compiles.

The attached patch adds a version-guarded branch that uses the value's
.c_str(), following the existing POPPLER_VERSION_MAJOR/MINOR convention,
so older poppler still builds. The change is fully guarded on
POPPLER_VERSION, so it is a no-op with the poppler currently in unstable
and can be applied now, ahead of the transition

Thanks
Nadzeya
-------------- next part --------------
Description: Fix FTBFS with poppler 26.04+
 poppler 26.04 changed Object::getString() to return a const
 std::string& instead of a GooString*, so title.getString()->c_str()
 no longer compiles.  Add a version-guarded branch using the value's
 .c_str(), following the existing POPPLER_VERSION_MAJOR/MINOR
 convention, so older poppler still builds
Author: Nadzeya Hutsko <nadzeya at ubuntu.com>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/2161747
Forwarded: no
Last-Update: 2026-07-24
--- a/src/pdf/XPDFRenderer.cpp
+++ b/src/pdf/XPDFRenderer.cpp
@@ -178,7 +178,10 @@
 #endif
             if (title.isString())
             {
-#if POPPLER_VERSION_MAJOR > 0 || POPPLER_VERSION_MINOR >= 72
+#if POPPLER_VERSION_MAJOR > 26 || (POPPLER_VERSION_MAJOR == 26 && POPPLER_VERSION_MINOR >= 4)
+                // poppler 26.04 made Object::getString() return a const std::string&
+                return QString(title.getString().c_str());
+#elif POPPLER_VERSION_MAJOR > 0 || POPPLER_VERSION_MINOR >= 72
                 return QString(title.getString()->c_str());
 #else
                 return QString(title.getString()->getCString());